Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Loosen versions for
numpy
,blis
to support M1 MacRelated issue(s)
#1695
Fixes # (issue)
#1695
Test plan
Need help on this
Checklist
Need help on these? Just ask!
Need help to test py36 and py37 as they are hard to install on M1 Mac.
Need help on
tox -e spark
Need help on CICD
Need help on what document to update
Need help on whether there should be new test cases
tox -e complex
and/ortox -e spark
if appropriate.** [X]
tox -e complex
runs and passes all test** [ ]
tox -e spark
is currently failing withException: Java gateway process exited before sending its port number
** [X]
tox -e py38
passes** [X]
tox -e complex
passes** [X]
tox -e doctest
passes** [X]
tox -e check
passes** [X]
tox -e type
passes (all code changes are regarding this)** [ ]
tox -e py36 # Run unit tests pytest in Python 3.6
** [ ]
tox -e py37 # Run unit tests pytest in Python 3.7
** [ ]
tox -e spark # Run Spark-based tests (marked with @pytest.mark.spark)
** [ ]
tox -e doc # Build documentation with Sphinx