Skip to content

Conversation

zexuan-zhou
Copy link
Contributor

@zexuan-zhou zexuan-zhou commented Apr 12, 2022

Description of proposed changes

Loosen versions for numpy, blis to support M1 Mac

Related issue(s)

#1695

Fixes # (issue)
#1695

Test plan

Need help on this

Checklist

Need help on these? Just ask!
Need help to test py36 and py37 as they are hard to install on M1 Mac.
Need help on tox -e spark
Need help on CICD
Need help on what document to update
Need help on whether there should be new test cases

  • I have read the CONTRIBUTING document.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have run tox -e complex and/or tox -e spark if appropriate.
    ** [X] tox -e complex runs and passes all test
    ** [ ] tox -e spark is currently failing with Exception: Java gateway process exited before sending its port number
  • All new and existing tests passed.
    ** [X] tox -e py38 passes
    ** [X] tox -e complex passes
    ** [X] tox -e doctest passes
    ** [X] tox -e check passes
    ** [X] tox -e type passes (all code changes are regarding this)
    ** [ ] tox -e py36 # Run unit tests pytest in Python 3.6
    ** [ ] tox -e py37 # Run unit tests pytest in Python 3.7
    ** [ ] tox -e spark # Run Spark-based tests (marked with @pytest.mark.spark)
    ** [ ] tox -e doc # Build documentation with Sphinx

@zexuan-zhou zexuan-zhou marked this pull request as ready for review April 12, 2022 19:04
@zexuan-zhou
Copy link
Contributor Author

@rsmith49 @bhancock8 Please take a look. I need some help on the tests for py36, py37, and spark, and CICD. Thank you

@zexuan-zhou zexuan-zhou mentioned this pull request Apr 12, 2022
@rsmith49
Copy link
Contributor

@zexuan-zhou thanks for getting going here! Can you re-create this PR to merge into snorkel-team:update-numpy-version instead of snorkel-team:master? That way we can run the checks in CI after merging in these changes before merging into master

@zexuan-zhou zexuan-zhou changed the base branch from master to update-numpy-version April 12, 2022 20:29
@zexuan-zhou
Copy link
Contributor Author

@zexuan-zhou thanks for getting going here! Can you re-create this PR to merge into snorkel-team:update-numpy-version instead of snorkel-team:master? That way we can run the checks in CI after merging in these changes before merging into master

@rsmith49 Done. Changed the base to snorkel-team:update-numpy-version

@rsmith49 rsmith49 merged commit 2df8f7d into snorkel-team:update-numpy-version Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants