simulator: Write dependency logs to separate files #7433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- apply workspace filter - enable dependency logging
ackintosh
changed the title
macladson
approved these changes
May 13, 2025
|
Nice, thanks for fixing this 🙏 |
jimmygchen
added
ready-for-merge
6 tasks
mergify bot
pushed a commit
that referenced
this pull request
May 30, 2025
The simulator works but always emits the following message: ``` $ cargo run --release --bin simulator basic-sim ... ... Failed to initialize dependency logging: attempted to set a logger after the logging system was already initialized ... ... ``` This PR removes the initialization with `env_logger`. (Update) With #7433 merged, the libp2p/discv5 logs are saved in separate files and respect the `RUST_LOG` env var for log level configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR relates to:
Building on these, this PR enables dependency logging for the simulators. The logs are written to separate files.
The libp2p/discv5 logs:
--log-dirRUST_LOGenvironment variable for log level configurationAdditional Info
The logs can be downloaded as follows: