simulator: Persist beacon logs #7394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macladson
approved these changes
May 7, 2025
|
Thanks for your feedback! That makes sense. I'll go ahead and add |
|
Done. It looks much cleaner. ✨ |
|
This pull request has merge conflicts. Could you please resolve them @ackintosh? 🙏 |
# Conflicts: # .github/workflows/test-suite.yml # testing/simulator/src/basic_sim.rs
macladson
added
ready-for-merge
6 tasks
mergify bot
pushed a commit
that referenced
this pull request
May 15, 2025
This PR relates to: - #7199 - -> workspace_filter has been enabled (dependency logging has been disabled) - #7394 - -> file logging has been optionally enabled Building on these, this PR enables dependency logging for the simulators. The logs are written to separate files. The libp2p/discv5 logs: - are saved to the directory specified with `--log-dir` - respects the `RUST_LOG` environment variable for log level configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Beacon logs in the simulator are printed only to stdout. The logs are usually large, so persisting them would be helpful for debugging.
Proposed Changes
Added
--log-dirparameter to the simulators and a step to upload the logs to Artifacts.(Update)
Added
--disable-stdout-loggingto disable stdout logging, making the CI page cleaner.Additional Info
I have checked that the CI works and the beacon logs are available for download.