Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion slasher/src/database/lmdb_impl.rs
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,12 @@ impl<'env> Cursor<'env> {
}

pub fn get_current(&mut self) -> Result<Option<(Key<'env>, Value<'env>)>, Error> {
// FIXME: lmdb has an extremely broken API which can mutate the SHARED REFERENCE
// `value` after `get_current` is called. We need to convert it to a Vec here in order
// to avoid `value` changing after another cursor operation. I think this represents a bug
// in the LMDB bindings, as shared references should be immutable.
if let Some((Some(key), value)) = self.cursor.get(None, None, MDB_GET_CURRENT).optional()? {
Ok(Some((Cow::Borrowed(key), Cow::Borrowed(value))))
Ok(Some((Cow::Borrowed(key), Cow::Owned(value.to_vec()))))
} else {
Ok(None)
}
Expand Down
5 changes: 5 additions & 0 deletions slasher/tests/random.rs
Original file line number Diff line number Diff line change
Expand Up @@ -235,3 +235,8 @@ fn no_crash_blocks_example1() {
},
);
}

#[test]
fn no_crash_aug_24() {
random_test(13519442335106054152, TestConfig::default())
}
Loading