Work around UB in LMDB bindings #6211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
bug
|
Thanks @jimmygchen for helping debug this. I'll have another follow-up PR that fixes the file descriptor leak in the iterated tests. I want to keep it separate from this PR because it involves |
jimmygchen
added
ready-for-merge
|
Nice, let's deploy this fix to our testnet slasher. |
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 0bb2386 |
|
For reference, I think the exact type of UB triggered was:
From https://doc.rust-lang.org/reference/behavior-considered-undefined.html |
AgeManning
pushed a commit
to AgeManning/lighthouse
that referenced
this pull request
Sep 3, 2024
* Work around UB in LMDB bindings
chong-he
pushed a commit
to chong-he/lighthouse
that referenced
this pull request
Nov 26, 2024
* Work around UB in LMDB bindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Fix a crazy memory corruption bug in the LMDB slasher impl.
Proposed Changes
Copy the contents of the cursor's
valueprior to returning it, so that LMDB can't mutate the data being pointed to when.delete_current()is called.Additional Info
This possibly explains the strange behaviour seen on some slasher nodes:
The bug had existed latently for a long time, but only now became executable with the refactor in: