-
Notifications
You must be signed in to change notification settings - Fork 36
Refactor form control sizing #1005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 26 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
3f9fd46
visual test setup
lindsaym-fa e964a7b
fix improper class placement in visual tests
lindsaym-fa f5f07e5
add `wa-form-control-*-font-size` and `-wa-form-control-hint-*` custo…
lindsaym-fa 943d7b1
use new custom properties
lindsaym-fa 2a9483f
dump of component sizing improvements
lindsaym-fa ed7309f
fix native color picker styles
lindsaym-fa ced5e46
Merge branch 'next' into lm/form-control-sizing
lindsaym-fa 572ce03
Merge branch 'next' into lm/form-control-sizing
lindsaym-fa 736e315
update menu with relative sizes
lindsaym-fa 1ace67d
tidy up menu, select, and tag sizing
lindsaym-fa b7c16d8
use relative sizing across components
lindsaym-fa d45b91e
touch up custom properties
lindsaym-fa 5369fdb
update docs and comments
lindsaym-fa c86adb0
update changelog
lindsaym-fa 3c4507f
Merge branch 'next' into lm/form-control-sizing
lindsaym-fa 8a28970
revert changes to visual tests to simplify PR
lindsaym-fa fa685ec
revert leftover change to visual tests
lindsaym-fa e944626
tidy up space doc markdown
lindsaym-fa d8a90e7
fix default card spacing
lindsaym-fa 1f552d1
fix card docs
lindsaym-fa dbdddb8
wrap up new `--tag-max-size` for `<wa-select>`
lindsaym-fa 05d738f
change default `--tag-max-size`
lindsaym-fa 2461375
prettier
lindsaym-fa 1eaeeba
touch up
lindsaym-fa c619eb5
clean up leftovers
lindsaym-fa f8ba906
fix native form control margins
lindsaym-fa 2923a55
set default toggle size relative to font size
lindsaym-fa cc513d2
correct toggle size in docs
lindsaym-fa ffd856d
Merge branch 'next' into lm/form-control-sizing
lindsaym-fa 9da4ce4
Konnorrogers/lm form control sizing (#1025)
KonnorRogers ddf3b54
Merge branch 'next' into lm/form-control-sizing
lindsaym-fa abbfe14
add workflow dispatch for client tests
KonnorRogers f681434
Merge branch 'lm/form-control-sizing' of https://github.com/shoelace-…
KonnorRogers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.