Refactor form control sizing #1005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
claviska
previously approved these changes
Jun 3, 2025
claviska
previously approved these changes
Jun 3, 2025
claviska
previously approved these changes
Jun 3, 2025
* try a second updateComplete?? * try a second updateComplete?? * more timeouts? * try logging * more logging gp * maybe now * radio group test * add todo note'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work removes a ton of obscure logic from our
size.cssutility and instead relies on relative sizing for our components. To do so, this PR —size.css, including--wa-size,--wa-size-smaller,--wa-size-larger,--wa-space,--wa-space-smaller,--wa-space-larger,--size-*,--space-*, etc.size=""need only setfont-sizeto take effect--wa-form-control-padding-inline(default1em)--wa-form-control-padding-block(default0.75em)--wa-form-control-toggle-size(default1lh)--wa-form-control-heightfromstyles/utilities/size.css>styles/themes/groups.css--wa-font-size-*tokens to use accurate typescale calculations to better support new properties for--wa-font-size-smallerand--wa-font-size-largerAdditionally, I snuck the following changes in (easily reverted if we're at all concerned) —
--checked-icon-scaleto<wa-checkbox>to better match the interface of<wa-radio>(addresses Missing --checked-icon-scale on wa-checkbox webawesome-alpha#145)--tag-max-sizeto<wa-select>so that folks can overrides the max width of the tags when usingmultiple(addresses Tag max-width limitation in <wa-select> webawesome-alpha#166)--wa-form-control-hint-color--wa-form-control-hint-font-weight--wa-form-control-hint-line height<wa-color-picker>and<input type="color">to match the border radius of other inputs rather than being circularRelated bugs —
<wa-input>#626<wa-button>height doesn't match other inputs in some themes #631<wa-textarea rows="1">should match height of a normal input #632<textarea>and<wa-textarea>don't have identical heights #633