-
Notifications
You must be signed in to change notification settings - Fork 9
Add beast init
for Issue 417
#426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: bl4ze/dev
Are you sure you want to change the base?
Conversation
Implemented Suggestions
|
Also,@kunrex, I would like to have a demo run for this before approving changes. |
_, selectedMinute, err := minuteSelection.Run() | ||
if err != nil { | ||
log.Errorln("Failed to read input... defaulting to now...") | ||
return now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be we can have the correctly parsed incomplete time with some fix instead of defaulting to now. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so we just default it to something if it fails? like if it fails on hours then just default it to 00 minutes, UTC or smthg like that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. Something of that sorts. However, I am not too convinced of the idea and would like to know your opinion on the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah i think its better than now, also the prompt only really fails if the user ctrl+c', with that in mind what can we default it to?
Add
beast init
for Issue 417Primary Changes:
.beast
directoriesbeast_authorized_keys
file in accordance to the example config. Does not create asecret.key
since no usages were foundSecondary Change:
init
frommain.go
beast run
checks for existence of.beast
folders before running