Skip to content

Conversation

gabyx
Copy link
Contributor

@gabyx gabyx commented Mar 31, 2025

Proposed Changes

  • Loading config values for quitsh CLI configuration does not allow to overwrite stuff by an env variable.
  • Here we load over mapstructure with viper.
  • Its not yet integrated, still WIP.

Types of Changes

What types of changes does your contribution introduce? Put an x in the boxes
that apply

  • A bug fix (non-breaking change which fixes an issue). Use MR tag
    bugfix.
  • A new feature (non-breaking change which adds functionality). Use MR
    tag feature.
  • A breaking change (fix or feature that would cause existing
    functionality to not work as expected). Use MR tag feature.
  • A non-productive update (documentation, tooling, etc. if none of the
    other choices apply). Use MR tag chore.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

Further Comments

@gabyx gabyx marked this pull request as draft March 31, 2025 11:15
@gabyx gabyx changed the title fix: add load2 which loads over viper/mapstructure to overwrite with env fix: add config load over viper/mapstructure to overwrite with env Mar 31, 2025
Copy link

codecov bot commented Mar 31, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@gabyx gabyx force-pushed the feat/add-env-parsing-over-viper branch from 9215516 to bbe6cba Compare June 15, 2025 19:30
@gabyx
Copy link
Contributor Author

gabyx commented Jun 28, 2025

Closed as solved by #29

@gabyx gabyx closed this Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant