Skip to content

Conversation

gabyx
Copy link
Contributor

@gabyx gabyx commented Jun 15, 2025

Proposed Changes

  • Parse stdin config file with -.
  • Set config values on every level with --config-value "a.b.c: 123" etc.

Types of Changes

What types of changes does your contribution introduce? Put an x in the boxes
that apply

  • A bug fix (non-breaking change which fixes an issue). Use MR tag
    bugfix.
  • A new feature (non-breaking change which adds functionality). Use MR
    tag feature.
  • A breaking change (fix or feature that would cause existing
    functionality to not work as expected). Use MR tag feature.
  • A non-productive update (documentation, tooling, etc. if none of the
    other choices apply). Use MR tag chore.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

Further Comments

Copy link

codecov bot commented Jun 15, 2025

Codecov Report

Attention: Patch coverage is 66.80498% with 80 lines in your changes missing coverage. Please review.

Project coverage is 61.14%. Comparing base (75322d1) to head (b493492).

Files with missing lines Patch % Lines
pkg/config/config-key-values.go 70.31% 15 Missing and 4 partials ⚠️
pkg/cli/cmd/root/root.go 85.00% 11 Missing and 4 partials ⚠️
pkg/image/image-type.go 36.84% 12 Missing ⚠️
pkg/registry/registry-type.go 0.00% 12 Missing ⚠️
pkg/common/env_type.go 0.00% 9 Missing ⚠️
pkg/component/component-version.go 0.00% 6 Missing ⚠️
pkg/common/build-type.go 66.66% 2 Missing and 1 partial ⚠️
pkg/config/hooks.go 75.00% 2 Missing and 1 partial ⚠️
pkg/component/component-paths.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   61.53%   61.14%   -0.39%     
==========================================
  Files          90       92       +2     
  Lines        4877     5032     +155     
==========================================
+ Hits         3001     3077      +76     
- Misses       1638     1709      +71     
- Partials      238      246       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gabyx gabyx force-pushed the feat/add-stdin-parse-and-key-value-pairs branch from 1933ff7 to b33c4df Compare June 15, 2025 19:51
@gabyx gabyx force-pushed the feat/add-stdin-parse-and-key-value-pairs branch from d079046 to c58fc12 Compare June 28, 2025 12:00
@gabyx gabyx force-pushed the feat/add-stdin-parse-and-key-value-pairs branch from c6abc86 to 7853eac Compare June 28, 2025 12:28
@gabyx gabyx merged commit cb5b1a6 into main Jun 28, 2025
6 of 7 checks passed
@gabyx gabyx deleted the feat/add-stdin-parse-and-key-value-pairs branch June 28, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant