Skip to content

Conversation

@anurag4DSB
Copy link

Instead of watching all pods in the mountpoint namespace cluster-wide, each node only watches its own pods. The pod watcher now filters pods to only those scheduled on the specific node, significantly reducing API server load

@codecov
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 67.34694% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.10%. Comparing base (07967ab) to head (efdcc68).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
pkg/driver/node/mounter/pod_mounter.go 70.83% 6 Missing and 1 partial ⚠️
pkg/podmounter/mppod/watcher/watcher.go 70.58% 3 Missing and 2 partials ⚠️
pkg/mountpoint/mounter/mount.go 42.85% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
pkg/driver/driver.go 46.49% <100.00%> (ø)
pkg/mountpoint/mounter/mount.go 69.23% <42.85%> (-6.53%) ⬇️
pkg/podmounter/mppod/watcher/watcher.go 79.72% <70.58%> (+0.36%) ⬆️
pkg/driver/node/mounter/pod_mounter.go 63.33% <70.83%> (+7.19%) ⬆️

... and 1 file with indirect coverage changes

@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
+ Coverage   71.47%   72.10%   +0.63%     
==========================================
  Files          47       47              
  Lines        3274     3309      +35     
==========================================
+ Hits         2340     2386      +46     
+ Misses        813      797      -16     
- Partials      121      126       +5     

@anurag4DSB anurag4DSB force-pushed the improvement/S3CSI-184-Pod-Watcher-with-NodeID branch from a7fb701 to adf3208 Compare September 29, 2025 06:32
@anurag4DSB anurag4DSB marked this pull request as ready for review September 29, 2025 06:32
@anurag4DSB anurag4DSB changed the title S3CSI-184: pod watcher with node S3CSI-184: pod watcher with node ID Sep 29, 2025
@anurag4DSB anurag4DSB requested a review from a team September 29, 2025 07:29
Base automatically changed from feature/S3CSI-179-single-atomic-switch-v2-architecture to main September 29, 2025 12:54
- Add nodeID parameter to watcher to filter pods by node
- Update all watcher initialization calls to include nodeID
- Add isNodeMatch() helper to filter pods to specific nodes
- Update tests to provide nodeID for watcher creation
@anurag4DSB anurag4DSB force-pushed the improvement/S3CSI-184-Pod-Watcher-with-NodeID branch from 41815a7 to efdcc68 Compare September 29, 2025 19:49
@anurag4DSB anurag4DSB merged commit 31392f9 into main Sep 29, 2025
11 checks passed
@anurag4DSB anurag4DSB deleted the improvement/S3CSI-184-Pod-Watcher-with-NodeID branch September 29, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants