forked from awslabs/mountpoint-s3-csi-driver
-
Notifications
You must be signed in to change notification settings - Fork 0
S3CSI-184: pod watcher with node ID #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
anurag4DSB
merged 3 commits into
main
from
improvement/S3CSI-184-Pod-Watcher-with-NodeID
Sep 29, 2025
Merged
S3CSI-184: pod watcher with node ID #244
anurag4DSB
merged 3 commits into
main
from
improvement/S3CSI-184-Pod-Watcher-with-NodeID
Sep 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files
... and 1 file with indirect coverage changes @@ Coverage Diff @@
## main #244 +/- ##
==========================================
+ Coverage 71.47% 72.10% +0.63%
==========================================
Files 47 47
Lines 3274 3309 +35
==========================================
+ Hits 2340 2386 +46
+ Misses 813 797 -16
- Partials 121 126 +5 |
a7fb701 to
adf3208
Compare
BourgoisMickael
approved these changes
Sep 29, 2025
dvasilas
approved these changes
Sep 29, 2025
Base automatically changed from
feature/S3CSI-179-single-atomic-switch-v2-architecture
to
main
September 29, 2025 12:54
- Add nodeID parameter to watcher to filter pods by node - Update all watcher initialization calls to include nodeID - Add isNodeMatch() helper to filter pods to specific nodes - Update tests to provide nodeID for watcher creation
41815a7 to
efdcc68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of watching all pods in the mountpoint namespace cluster-wide, each node only watches its own pods. The pod watcher now filters pods to only those scheduled on the specific node, significantly reducing API server load