S3CSI-184: Add node ID in watcher for the nodes to watch activity on and Add CSI daemon detection to controller #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anurag4DSB
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 1 file with indirect coverage changes @@ Coverage Diff @@
## feature/S3CSI-179-single-atomic-switch-v2-architecture #242 +/- ##
==========================================================================================
+ Coverage 71.44% 71.57% +0.13%
==========================================================================================
Files 47 47
Lines 3274 3279 +5
==========================================================================================
+ Hits 2339 2347 +8
+ Misses 814 812 -2
+ Partials 121 120 -1 |
- Implement CSINode-based detection before creating Mountpoint Pods - Add ConfigMap fallback for additional node status tracking - Integrate EventRecorder for clear user feedback via Kubernetes events - Update RBAC to include CSINode and ConfigMap read permissions - Add comprehensive tests for CSI detection scenarios - Optimize for OpenShift/ROSA with SELinux enforcing mode This prevents workload pods from getting stuck in ContainerCreating state when scheduled on nodes without the S3 CSI daemon installed, improving user experience and resource efficiency.
- Add PodWatcher interface to enable dependency injection - Update PodMounter to use interface instead of concrete watcher type - Implement mock PodWatcher for unit tests to avoid K8s dependencies - Fix socket communication in tests using simplified mock approach - Update pod_unmounter tests to implement Wait method in mock - Remove unused setMountOptions method This change fixes unit test failures caused by tests attempting to interact with real Kubernetes resources. The tests were timing out waiting for pod state transitions and socket communication that would never occur without a real cluster. By introducing the PodWatcher interface and mock implementation, tests now run as true unit tests without external dependencies, making them faster and more reliable.
anurag4DSB
force-pushed
the
improvement/S3CSI-184-Enhanced-Pod-Watcher-with-NodeID
branch
from
708bf79 to
c7d6578
Compare
Author
|
closoijng in favor of #244 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements CSI daemon detection to prevent Mountpoint Pod creation on nodes without the CSI driver running, adds node ID tracking in watchers for node-specific activity monitoring, and improves test infrastructure with proper mocking and CSINode objects for reliable integration testing.