fix a few tests #3897
Merged
fix a few tests #3897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebcartwright
changed the title
scampi
suggested changes
Oct 30, 2019
calebcartwright
force-pushed
the
fix-test-nested-int-file
branch
from
b467717 to
f82171a
Compare
scampi
approved these changes
Oct 31, 2019
Contributor
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few tests added by me in some recent PRs that were missing some things 😞
Two tests (
config::test::test_valid_license_template_pathand a system tests for handling ignored files that contain parser errors) were missing the unstable/nightly check, so they were failing on the Travis job that runs on beta: https://travis-ci.com/rust-lang/rustfmt/jobs/250084463The other test fixed here is one of the tests I added in #3777 that was a little flaky as originally written. This updates the asserts in the test to eliminate that flakiness.
Below job links show the original version failing due to the ordering of the discovered files in the vec
https://travis-ci.com/rust-lang/rustfmt/jobs/250683618
and https://travis-ci.com/rust-lang/rustfmt/jobs/250390989