deprecate skip_children option

[scampi]

Close #3893

[topecongiro]

Thank you for the PR, LGTM other than the dbg! call.

[topecongiro]

Sorry, could you fix the CI errors? Also, I wonder why Travis is green even when some of the tests have failed 🤔

[scampi]

@topecongiro the Travis build now correctly fails when test fail d57f94a

[scampi]

The beta build failed because of some reason unrelated to this PR. I'll try to check why.

error: invalid suffix `x` for integer literal
 --> tests/source/issue-3779/ice.rs:2:5
  |
2 |     1x;
  |     ^^ invalid suffix `x`
  |
  = help: the suffix must be one of the integral types (`u32`, `isize`, etc)

[calebcartwright]

That was added as part of #3782, though that file is supposed to be ignored

[calebcartwright]

There's warning about unstable options in the output just above the failure which means that file isn't being ignore'd like it should be

Warning: can't set `unstable_features = true`, unstable features are only available in nightly channel.
Warning: can't set `ignore = IgnoreList { path_set: {"tests/**/issue-3779/ice.rs"}, rustfmt_toml_path: "" }`, unstable features are only available in nightly channel.

Any reason why the unstable options wouldn't be working on that one?

[scampi]

@calebcartwright I'll have a look about why ice.rs is not ignored.

[calebcartwright]

@scampi - I believe I found the issue and have opened #3897 with fixes. I added these tests but missed the unstable/nightly check which is why they were failing on beta.

My apologies!