Remove unused HVC64 and SMC64 values from ESR_EL1.EC #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tanyan <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the HVC64 and SMC64 exception class values from the ESR_EL1 register definition, correctly aligning it with ARM architecture specifications. HVC (Hypervisor Call) exceptions are always taken to EL2 and SMC (Secure Monitor Call) exceptions are taken to EL3, so these exception codes can never appear in ESR_EL1.
- Removes architecturally invalid HVC64 (0b01_0110) exception class from ESR_EL1
- Removes architecturally invalid SMC64 (0b01_0111) exception class from ESR_EL1
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #64
Please review it when have time ;)
Thanks