Skip to content

Conversation

@silanus23
Copy link
Contributor

@silanus23 silanus23 commented Dec 8, 2025


Basic Info

Info Please fill out this column
Ticket(s) this addresses ros-navigation/navigation2#5602
Does this PR contain AI-generated software? nope

Description of contribution in a few bullet points

I needed to add widen the first column just a liiitle bit. If I should have done it other way I can fix it. @mini-1235

Copilot AI review requested due to automatic review settings December 8, 2025 12:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds documentation for a new behavior tree condition plugin called "Is Within Path Tracking Bounds Condition" to the plugin index table. To accommodate the longer plugin name, the first column of the condition plugins table is widened from 36 to 46 characters, with all existing rows reformatted accordingly.

Key Changes:

  • Added new table row for "Is Within Path Tracking Bounds Condition" with creator Berkan Tali
  • Widened first column of the condition plugins table to fit longer plugin names
  • Added reference link to the condition's source code

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

| | Purnawan | occupied. |
+----------------------------------------------+--------------------+------------------------+
| `Is Within Path Tracking Bounds Condition`_ | Berkan Tali | Checks if robot is |
| | | within determined |
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description "Checks if robot is within determined bounds" is vague and less specific than other entries in the table. Consider clarifying what kind of bounds are being checked. For example: "Checks if robot is within path tracking bounds" or "Checks if robot is within configured tracking bounds".

Suggested change
| | | within determined |
| | | within path tracking |

Copilot uses AI. Check for mistakes.
@SteveMacenski
Copy link
Member

SteveMacenski commented Dec 8, 2025

@mini-1235 to review

Also check out the precommit error. Also add this to the configuration guide / parameter guide (if the BT node has any ports)

Copy link
Collaborator

@mini-1235 mini-1235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing configuration guide + migration guide

Signed-off-by: silanus23 <[email protected]>
Signed-off-by: silanus23 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants