-
Notifications
You must be signed in to change notification settings - Fork 234
added is within path tracking bounds condition #815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: silanus23 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds documentation for a new behavior tree condition plugin called "Is Within Path Tracking Bounds Condition" to the plugin index table. To accommodate the longer plugin name, the first column of the condition plugins table is widened from 36 to 46 characters, with all existing rows reformatted accordingly.
Key Changes:
- Added new table row for "Is Within Path Tracking Bounds Condition" with creator Berkan Tali
- Widened first column of the condition plugins table to fit longer plugin names
- Added reference link to the condition's source code
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | | Purnawan | occupied. | | ||
| +----------------------------------------------+--------------------+------------------------+ | ||
| | `Is Within Path Tracking Bounds Condition`_ | Berkan Tali | Checks if robot is | | ||
| | | | within determined | |
Copilot
AI
Dec 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description "Checks if robot is within determined bounds" is vague and less specific than other entries in the table. Consider clarifying what kind of bounds are being checked. For example: "Checks if robot is within path tracking bounds" or "Checks if robot is within configured tracking bounds".
| | | | within determined | | |
| | | | within path tracking | |
|
@mini-1235 to review Also check out the precommit error. Also add this to the configuration guide / parameter guide (if the BT node has any ports) |
mini-1235
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing configuration guide + migration guide
Signed-off-by: silanus23 <[email protected]>
Signed-off-by: silanus23 <[email protected]>
Signed-off-by: silanus23 <[email protected]>
Basic Info
Description of contribution in a few bullet points
I needed to add widen the first column just a liiitle bit. If I should have done it other way I can fix it. @mini-1235