Rename BT nodes and move parameter filter duration #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed typos in documentation - Updated outdated links in docs - Renamed Behavior Tree (BT) nodes for consistency - Moved parameter filter duration from speed controller to BT Navigator Signed-off-by: Maurice-1235 <[email protected]>
mini-1235
changed the title
SteveMacenski
requested changes
Mar 6, 2025
Member
SteveMacenski
left a comment
SteveMacenski
left a comment
There was a problem hiding this comment.
My consistent dyslexia strikes again 😆
configuration/packages/bt-plugins/conditions/GlobalUpdatedGoal.rst
Outdated
Show resolved
Hide resolved
Signed-off-by: Maurice-1235 <[email protected]>
Collaborator
Author
|
I just noticed that the node |
Signed-off-by: Maurice-1235 <[email protected]>
Signed-off-by: Maurice-1235 <[email protected]>
Collaborator
Author
|
Mostly copied from the condition node |
configuration/packages/bt-plugins/decorators/GoalUpdatedController.rst
Outdated
Show resolved
Hide resolved
Signed-off-by: Maurice-1235 <[email protected]>
SteveMacenski
approved these changes
Mar 6, 2025
Member
|
@mini-1235 can you open a new PR with this content and close out this one? This PR got into a weird state on GitHub and is refusing to let me merge it in thinking that it is in the process of being merged in another session. Not sure what's up with that. |
Member
|
oop, there it goes, disregard! |
mini-1235
added a commit
to mini-1235/docs.nav2.org
that referenced
this pull request
Mar 21, 2025
* Update docs - Fixed typos in documentation - Updated outdated links in docs - Renamed Behavior Tree (BT) nodes for consistency - Moved parameter filter duration from speed controller to BT Navigator Signed-off-by: Maurice-1235 <[email protected]> * Fix to match rst style Signed-off-by: Maurice-1235 <[email protected]> * Add GoalUpdatedController node Signed-off-by: Maurice-1235 <[email protected]> * Add link for the node Signed-off-by: Maurice-1235 <[email protected]> * Add author name and example ports Signed-off-by: Maurice-1235 <[email protected]> --------- Signed-off-by: Maurice-1235 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up PR for ros-navigation/navigation2#4940, also some typos fixed and links updated