Skip to content

Conversation

ryanjulian
Copy link
Member

#1996 removed the >=2.0 constraint, which is important.

@ryanjulian ryanjulian requested a review from yeukfu September 3, 2020 00:25
@ryanjulian ryanjulian requested a review from a team as a code owner September 3, 2020 00:25
@ryanjulian ryanjulian requested review from krzentner and removed request for a team September 3, 2020 00:25
@mergify mergify bot requested review from a team and AiRuiChen and removed request for a team September 3, 2020 00:25
@mergify mergify bot requested a review from a team September 3, 2020 00:29
@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #1998 into master will increase coverage by 9.61%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1998      +/-   ##
==========================================
+ Coverage   83.92%   93.53%   +9.61%     
==========================================
  Files         190      190              
  Lines       10165    10165              
  Branches     1266     1266              
==========================================
+ Hits         8531     9508     +977     
+ Misses       1409      427     -982     
- Partials      225      230       +5     
Impacted Files Coverage Δ
src/garage/sampler/multiprocessing_sampler.py 90.60% <0.00%> (ø)
src/garage/_functions.py 100.00% <0.00%> (+0.97%) ⬆️
src/garage/envs/gym_env.py 97.52% <0.00%> (+1.65%) ⬆️
src/garage/torch/modules/gaussian_mlp_module.py 89.01% <0.00%> (+2.19%) ⬆️
src/garage/experiment/local_runner.py 91.03% <0.00%> (+2.83%) ⬆️
src/garage/torch/_functions.py 96.59% <0.00%> (+4.54%) ⬆️
src/garage/experiment/meta_evaluator.py 87.80% <0.00%> (+4.87%) ⬆️
src/garage/_environment.py 97.36% <0.00%> (+5.26%) ⬆️
src/garage/torch/policies/policy.py 100.00% <0.00%> (+6.25%) ⬆️
src/garage/np/optimizers/minibatch_dataset.py 89.28% <0.00%> (+7.14%) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4d689a...63ec5eb. Read the comment docs.

@mergify mergify bot merged commit 2f94000 into master Sep 3, 2020
@mergify mergify bot deleted the patch-1996 branch September 3, 2020 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants