Skip to content

Conversation

yeukfu
Copy link
Contributor

@yeukfu yeukfu commented Sep 2, 2020

The latest mujoco-py is broken because of gcc related bug. Currently we just pin its version to 2.0.2.8. This should close #1989.

@yeukfu yeukfu requested a review from a team as a code owner September 2, 2020 19:12
@mergify mergify bot requested review from a team and irisliucy and removed request for a team September 2, 2020 19:13
@ryanjulian ryanjulian added ready-to-merge backport-to-2020.06 Backport this PR to release-2020.06 labels Sep 2, 2020
@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #1996 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1996      +/-   ##
==========================================
- Coverage   93.55%   93.54%   -0.01%     
==========================================
  Files         190      190              
  Lines       10165    10165              
  Branches     1266     1266              
==========================================
- Hits         9510     9509       -1     
+ Misses        425      424       -1     
- Partials      230      232       +2     
Impacted Files Coverage Δ
...e/np/exploration_policies/epsilon_greedy_policy.py 96.42% <0.00%> (-3.58%) ⬇️
src/garage/np/_functions.py 89.34% <0.00%> (-1.64%) ⬇️
src/garage/sampler/multiprocessing_sampler.py 91.94% <0.00%> (+1.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c621a56...da7ebbb. Read the comment docs.

@gitanshu
Copy link
Contributor

gitanshu commented Sep 2, 2020

I hadn't tried changing mujoco-py versions because there are successful runs with 2.0.2.13:
https://github.com/rlworkgroup/garage/runs/1047294065?check_suite_focus=true#step:6:2680
https://travis-ci.com/github/rlworkgroup/garage/jobs/379169587#L5022

This started breaking 3 days ago but I don't see any new mujoco-py or conda releases in that period.

Anyway, I tried with different versions and somehow 2.0.2.8 works fine and so does 2.0.2.10 but 2.0.2.9 doesn't. Didn't find anything in the recent commits that would break stuff: https://github.com/openai/mujoco-py/commits/master

@yeukfu
Copy link
Contributor Author

yeukfu commented Sep 2, 2020

I hadn't tried changing mujoco-py versions because there are successful runs with 2.0.2.13:
https://github.com/rlworkgroup/garage/runs/1047294065?check_suite_focus=true#step:6:2680
https://travis-ci.com/github/rlworkgroup/garage/jobs/379169587#L5022

This started breaking 3 days ago but I don't see any new mujoco-py or conda releases in that period.

Anyway, I tried with different versions and somehow 2.0.2.8 works fine and so does 2.0.2.10 but 2.0.2.9 doesn't. Didn't find anything in the recent commits that would break stuff: https://github.com/openai/mujoco-py/commits/master

Yes, both conda and mujoco-py don't have any releases. I think this problem may be caused by some packages that mujoco-py relies on.

@ryanjulian ryanjulian merged commit a4d689a into master Sep 2, 2020
@ryanjulian
Copy link
Member

@Mergifyio backport release-2020.06

@mergify
Copy link
Contributor

mergify bot commented Sep 3, 2020

Command backport release-2020.06: failure

No backport have been created

  • Backport to branch release-2020.06 failed

Cherry-pick of a4d689a has failed:

On branch mergify/bp/release-2020.06/pr-1996
Your branch is up to date with 'origin/release-2020.06'.

You are currently cherry-picking commit a4d689a4.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)

	both modified:   setup.py

no changes added to commit (use "git add" and/or "git commit -a")

ryanjulian added a commit that referenced this pull request Sep 3, 2020
mergify bot pushed a commit that referenced this pull request Sep 9, 2020
@ryanjulian ryanjulian deleted the pin_mujoco_py branch September 14, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-2020.06 Backport this PR to release-2020.06 ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gcc: error: unrecognized command line option ‘-R’ (conda)
3 participants