-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat(bundler): Switch to ast-grep
parser
#37153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zharinov
wants to merge
30
commits into
renovatebot:main
Choose a base branch
from
zharinov:feat/bundler-ast-grep-parser
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,672
−721
Open
Changes from 12 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
eb34049
feat(bundler): Switch to `ast-grep` parser
zharinov 19725f4
Refactor
zharinov 1d99b44
Fixes
zharinov 1784aef
Variables
zharinov 26413a1
Fix signature
zharinov 52325a3
Fix tests
zharinov 7dc813a
Remove local package tests from bundler parser
zharinov 55d7c39
Merge branch 'main' into feat/bundler-ast-grep-parser
zharinov 3457e47
Fix lockfile
zharinov f9698ed
Fix line numbers
zharinov 9f44faf
Fix snapshots
zharinov 84f36c7
Fix autoreplace
zharinov 5dbc83c
Fix CI
zharinov eff96c7
Refactor
zharinov 4f3b0df
Replace GitRefData interface with type from PackageDependency
zharinov 87d5e8f
Rename bundler Ruby version parser files
zharinov 1ff7e7b
Refactor
zharinov e158f98
Fix coverage
zharinov d486fa9
Refactor
zharinov 3de61d7
Update git.spec.ts
zharinov e0ee628
Refactor
zharinov e2a8f8f
Add support for boolean key-value args in Bundler parser
zharinov 94e0359
Add support for optional gem groups
zharinov 16b412a
Add support for double Ruby version range extraction
zharinov 68f05b0
Merge branch 'main' into feat/bundler-ast-grep-parser
zharinov 42c93ee
Merge branch 'main' into feat/bundler-ast-grep-parser
zharinov 60767c1
Merge branch 'main' into feat/bundler-ast-grep-parser
zharinov c4dbf0e
Remove skipReason from Bundler parser and extract tests
zharinov d9fe3a7
Bump @ast-grep/napi from 0.39.1 to 0.39.3
zharinov 33fec4a
Remove unused common-tags import
zharinov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
1,247 changes: 516 additions & 731 deletions
1,247
lib/modules/manager/bundler/__snapshots__/extract.spec.ts.snap
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting, we extract without quotes. you need to check the ruby versioning if it needs the quotes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It strips them when needed