feat(bundler): Switch to ast-grep parser
#37153
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
viceice
reviewed
Jul 25, 2025
The commit focuses on adding proper handling of `optional` groups for Ruby gems in the Bundler manager.
secustor
reviewed
Aug 6, 2025
viceice
reviewed
Aug 13, 2025
| { depName: 'sfn_my_dep1', currentValue: '"~> 1"' }, | ||
| { depName: 'sfn_my_dep2', currentValue: '"~> 1"' }, | ||
| { | ||
| currentValue: '~> 1', |
There was a problem hiding this comment.
interesting, we extract without quotes. you need to check the ruby versioning if it needs the quotes!
There was a problem hiding this comment.
It strips them when needed
| strings: TemplateStringsArray, | ||
| ...values: any[] | ||
| ): NapiConfig { | ||
| return parseSingleYaml<NapiConfig>(strings[0]); |
There was a problem hiding this comment.
why so many arguments, when we only use the first string? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Gemfile Parser
A comprehensive Ruby Gemfile parser for Renovate built with AST-grep. The parser is organized into focused modules:
index.ts-parseGemfile()top-level functioncommon.ts- Shared AST utilities and Ruby language loading, i.g. variable resolutiongem.ts- Gem name/version parsing (gem "rails", "~> 7.0")git.ts- Git dependency handling (git:,github:,ref:,tag:,branch:)group-scope.ts- Dependency groups and scoping (group :development do ... end)ruby-version.ts- Ruby version requirements (ruby "2.7.1")source-scope.ts- Registry/source URL management (source "https://..." do ... end)Handles complex Gemfile syntax including nested groups, source blocks, variable resolution, version constraints, and edge cases.
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: