Fix:JedisCluster throws NullPointerException when maxAttempts is set to 0

[ggivo]

This change adds input validation to the RetryableCommandExecutor constructor to prevent usage with invalid configuration values, specifically when maxAttempts is set to 0.

Previously, setting maxAttempts to 0 in JedisCluster would result in a NullPointerException during command execution, due to lastException being uninitialized when no attempt is made. With this fix, an IllegalArgumentException is thrown early if maxAttempts < 1, providing feedback to the user.

Added unit tests to verify the validation behavior.

Co-authored-by: shivincible [email protected]

Fixes #4185

[Copilot]

Pull Request Overview

This PR adds input validation to prevent invalid configurations in retryable and cluster command executors and ensures unsupported usages fail fast. It introduces a shared assertion utility and expands test coverage for retry behavior.

• Introduce JedisAsserts for argument checks
• Add null and range checks in RetryableCommandExecutor and ClusterCommandExecutor constructors
• Add unit tests covering constructor validation and retry logic for RetryableCommandExecutor

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
src/main/java/redis/clients/jedis/util/JedisAsserts.java	New assertion utility for argument validation
src/main/java/redis/clients/jedis/executors/RetryableCommandExecutor.java	Constructor validations and suppressed-exception logic update
src/main/java/redis/clients/jedis/executors/ClusterCommandExecutor.java	Parallel validations and suppressed-exception logic in cluster executor
src/test/java/redis/clients/jedis/executors/RetryableCommandExecutorTest.java	Tests for constructor validation and retry behavior

Comments suppressed due to low confidence (3)

src/main/java/redis/clients/jedis/util/JedisAsserts.java:29

• The Javadoc for isTrue incorrectly references null elements in an object array. Update it to state that an IllegalArgumentException is thrown when the boolean value is false.

   * @throws IllegalArgumentException if the object array contains a {@code null} element

src/main/java/redis/clients/jedis/executors/RetryableCommandExecutor.java:30

• There is no unit test verifying that passing a null maxTotalRetriesDuration throws an IllegalArgumentException. Add a test case for this scenario in RetryableCommandExecutorTest.

    JedisAsserts.notNull(maxTotalRetriesDuration, "maxTotalRetriesDuration must not be null");

src/main/java/redis/clients/jedis/executors/ClusterCommandExecutor.java:34

• Constructor input validation in ClusterCommandExecutor isn't covered by tests. Add unit tests for null provider, invalid maxAttempts, and null maxTotalRetriesDuration.

    JedisAsserts.notNull(maxTotalRetriesDuration, "maxTotalRetriesDuration must not be null");

[atakavci]

LGTM!
nit: copilot warns around this

• @throws IllegalArgumentException if the object array contains a {@code null} element