-
Notifications
You must be signed in to change notification settings - Fork 312
Match Hands Off Config selectors on process_arguments value #9201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.1-SNAPSHOT~2cf109274c, baseline=1.51.1-SNAPSHOT~90125aff77
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.038 s) : 0, 1038481
Total [baseline] (8.606 s) : 0, 8605891
Agent [candidate] (1.04 s) : 0, 1039942
Total [candidate] (8.618 s) : 0, 8617726
section iast
Agent [baseline] (1.178 s) : 0, 1178208
Total [baseline] (9.3 s) : 0, 9300047
Agent [candidate] (1.174 s) : 0, 1174014
Total [candidate] (9.258 s) : 0, 9258417
gantt
title insecure-bank - break down per module: candidate=1.51.1-SNAPSHOT~2cf109274c, baseline=1.51.1-SNAPSHOT~90125aff77
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.446 ms) : 0, 1446
crashtracking [candidate] (1.423 ms) : 0, 1423
BytebuddyAgent [baseline] (729.696 ms) : 0, 729696
BytebuddyAgent [candidate] (730.446 ms) : 0, 730446
GlobalTracer [baseline] (241.29 ms) : 0, 241290
GlobalTracer [candidate] (241.834 ms) : 0, 241834
AppSec [baseline] (30.234 ms) : 0, 30234
AppSec [candidate] (30.367 ms) : 0, 30367
Debugger [baseline] (6.0 ms) : 0, 6000
Debugger [candidate] (5.996 ms) : 0, 5996
Remote Config [baseline] (646.688 µs) : 0, 647
Remote Config [candidate] (641.238 µs) : 0, 641
Telemetry [baseline] (8.207 ms) : 0, 8207
Telemetry [candidate] (8.224 ms) : 0, 8224
section iast
crashtracking [baseline] (1.439 ms) : 0, 1439
crashtracking [candidate] (1.431 ms) : 0, 1431
BytebuddyAgent [baseline] (850.201 ms) : 0, 850201
BytebuddyAgent [candidate] (847.646 ms) : 0, 847646
GlobalTracer [baseline] (233.676 ms) : 0, 233676
GlobalTracer [candidate] (231.603 ms) : 0, 231603
AppSec [baseline] (28.213 ms) : 0, 28213
AppSec [candidate] (28.153 ms) : 0, 28153
Debugger [baseline] (6.718 ms) : 0, 6718
Debugger [candidate] (6.655 ms) : 0, 6655
Remote Config [baseline] (602.518 µs) : 0, 603
Remote Config [candidate] (583.06 µs) : 0, 583
Telemetry [baseline] (7.883 ms) : 0, 7883
Telemetry [candidate] (7.914 ms) : 0, 7914
IAST [baseline] (28.539 ms) : 0, 28539
IAST [candidate] (29.065 ms) : 0, 29065
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.1-SNAPSHOT~2cf109274c, baseline=1.51.1-SNAPSHOT~90125aff77
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.04 s) : 0, 1040273
Total [baseline] (10.663 s) : 0, 10662858
Agent [candidate] (1.038 s) : 0, 1037851
Total [candidate] (10.577 s) : 0, 10576601
section appsec
Agent [baseline] (1.217 s) : 0, 1216513
Total [baseline] (10.768 s) : 0, 10767574
Agent [candidate] (1.219 s) : 0, 1218653
Total [candidate] (10.778 s) : 0, 10778016
section iast
Agent [baseline] (1.172 s) : 0, 1171703
Total [baseline] (10.987 s) : 0, 10986770
Agent [candidate] (1.175 s) : 0, 1175499
Total [candidate] (10.907 s) : 0, 10906919
section profiling
Agent [baseline] (1.186 s) : 0, 1186478
Total [baseline] (10.937 s) : 0, 10937493
Agent [candidate] (1.186 s) : 0, 1185581
Total [candidate] (10.864 s) : 0, 10864365
gantt
title petclinic - break down per module: candidate=1.51.1-SNAPSHOT~2cf109274c, baseline=1.51.1-SNAPSHOT~90125aff77
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.432 ms) : 0, 1432
crashtracking [candidate] (1.431 ms) : 0, 1431
BytebuddyAgent [baseline] (730.699 ms) : 0, 730699
BytebuddyAgent [candidate] (728.608 ms) : 0, 728608
GlobalTracer [baseline] (241.738 ms) : 0, 241738
GlobalTracer [candidate] (241.535 ms) : 0, 241535
AppSec [baseline] (30.476 ms) : 0, 30476
AppSec [candidate] (30.403 ms) : 0, 30403
Debugger [baseline] (6.043 ms) : 0, 6043
Debugger [candidate] (5.99 ms) : 0, 5990
Remote Config [baseline] (651.462 µs) : 0, 651
Remote Config [candidate] (644.664 µs) : 0, 645
Telemetry [baseline] (8.225 ms) : 0, 8225
Telemetry [candidate] (8.207 ms) : 0, 8207
section appsec
crashtracking [baseline] (1.437 ms) : 0, 1437
crashtracking [candidate] (1.436 ms) : 0, 1436
BytebuddyAgent [baseline] (751.115 ms) : 0, 751115
BytebuddyAgent [candidate] (752.44 ms) : 0, 752440
GlobalTracer [baseline] (234.286 ms) : 0, 234286
GlobalTracer [candidate] (234.87 ms) : 0, 234870
AppSec [baseline] (169.284 ms) : 0, 169284
AppSec [candidate] (170.003 ms) : 0, 170003
Debugger [baseline] (6.389 ms) : 0, 6389
Debugger [candidate] (6.427 ms) : 0, 6427
Remote Config [baseline] (602.833 µs) : 0, 603
Remote Config [candidate] (603.854 µs) : 0, 604
Telemetry [baseline] (8.805 ms) : 0, 8805
Telemetry [candidate] (8.167 ms) : 0, 8167
IAST [baseline] (23.389 ms) : 0, 23389
IAST [candidate] (23.415 ms) : 0, 23415
section iast
crashtracking [baseline] (1.433 ms) : 0, 1433
crashtracking [candidate] (1.44 ms) : 0, 1440
BytebuddyAgent [baseline] (845.659 ms) : 0, 845659
BytebuddyAgent [candidate] (847.759 ms) : 0, 847759
GlobalTracer [baseline] (232.077 ms) : 0, 232077
GlobalTracer [candidate] (232.154 ms) : 0, 232154
AppSec [baseline] (26.864 ms) : 0, 26864
AppSec [candidate] (27.478 ms) : 0, 27478
Debugger [baseline] (6.591 ms) : 0, 6591
Debugger [candidate] (9.305 ms) : 0, 9305
Remote Config [baseline] (594.962 µs) : 0, 595
Remote Config [candidate] (593.229 µs) : 0, 593
Telemetry [baseline] (7.914 ms) : 0, 7914
Telemetry [candidate] (7.903 ms) : 0, 7903
IAST [baseline] (29.653 ms) : 0, 29653
IAST [candidate] (27.715 ms) : 0, 27715
section profiling
ProfilingAgent [baseline] (103.958 ms) : 0, 103958
ProfilingAgent [candidate] (104.72 ms) : 0, 104720
crashtracking [baseline] (1.398 ms) : 0, 1398
crashtracking [candidate] (1.396 ms) : 0, 1396
BytebuddyAgent [baseline] (760.403 ms) : 0, 760403
BytebuddyAgent [candidate] (760.16 ms) : 0, 760160
GlobalTracer [baseline] (221.049 ms) : 0, 221049
GlobalTracer [candidate] (221.035 ms) : 0, 221035
AppSec [baseline] (30.342 ms) : 0, 30342
AppSec [candidate] (30.237 ms) : 0, 30237
Debugger [baseline] (6.267 ms) : 0, 6267
Debugger [candidate] (6.272 ms) : 0, 6272
Remote Config [baseline] (690.091 µs) : 0, 690
Remote Config [candidate] (677.175 µs) : 0, 677
Telemetry [baseline] (13.866 ms) : 0, 13866
Telemetry [candidate] (12.484 ms) : 0, 12484
Profiling [baseline] (103.981 ms) : 0, 103981
Profiling [candidate] (104.743 ms) : 0, 104743
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~2cf109274c, baseline=1.51.1-SNAPSHOT~90125aff77
dateFormat X
axisFormat %s
section baseline
no_agent (4.605 ms) : 4552, 4659
. : milestone, 4605,
iast (9.463 ms) : 9302, 9625
. : milestone, 9463,
iast_FULL (14.118 ms) : 13833, 14404
. : milestone, 14118,
iast_GLOBAL (10.109 ms) : 9934, 10283
. : milestone, 10109,
profiling (9.032 ms) : 8871, 9194
. : milestone, 9032,
tracing (7.439 ms) : 7336, 7543
. : milestone, 7439,
section candidate
no_agent (4.491 ms) : 4440, 4543
. : milestone, 4491,
iast (9.478 ms) : 9322, 9634
. : milestone, 9478,
iast_FULL (14.108 ms) : 13831, 14385
. : milestone, 14108,
iast_GLOBAL (10.23 ms) : 10043, 10416
. : milestone, 10230,
profiling (8.713 ms) : 8574, 8852
. : milestone, 8713,
tracing (7.715 ms) : 7603, 7827
. : milestone, 7715,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~2cf109274c, baseline=1.51.1-SNAPSHOT~90125aff77
dateFormat X
axisFormat %s
section baseline
no_agent (37.957 ms) : 37653, 38261
. : milestone, 37957,
appsec (48.414 ms) : 47982, 48847
. : milestone, 48414,
code_origins (43.834 ms) : 43470, 44198
. : milestone, 43834,
iast (44.22 ms) : 43842, 44597
. : milestone, 44220,
profiling (49.44 ms) : 48968, 49912
. : milestone, 49440,
tracing (44.771 ms) : 44388, 45154
. : milestone, 44771,
section candidate
no_agent (36.457 ms) : 36162, 36753
. : milestone, 36457,
appsec (47.97 ms) : 47541, 48399
. : milestone, 47970,
code_origins (45.171 ms) : 44776, 45567
. : milestone, 45171,
iast (44.999 ms) : 44613, 45385
. : milestone, 44999,
profiling (49.596 ms) : 49122, 50071
. : milestone, 49596,
tracing (42.441 ms) : 42078, 42804
. : milestone, 42441,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~2cf109274c, baseline=1.51.1-SNAPSHOT~90125aff77
dateFormat X
axisFormat %s
section baseline
no_agent (15.597 s) : 15597000, 15597000
. : milestone, 15597000,
appsec (14.823 s) : 14823000, 14823000
. : milestone, 14823000,
iast (18.5 s) : 18500000, 18500000
. : milestone, 18500000,
iast_GLOBAL (18.204 s) : 18204000, 18204000
. : milestone, 18204000,
profiling (15.18 s) : 15180000, 15180000
. : milestone, 15180000,
tracing (14.766 s) : 14766000, 14766000
. : milestone, 14766000,
section candidate
no_agent (15.312 s) : 15312000, 15312000
. : milestone, 15312000,
appsec (14.881 s) : 14881000, 14881000
. : milestone, 14881000,
iast (18.452 s) : 18452000, 18452000
. : milestone, 18452000,
iast_GLOBAL (18.074 s) : 18074000, 18074000
. : milestone, 18074000,
profiling (15.108 s) : 15108000, 15108000
. : milestone, 15108000,
tracing (15.123 s) : 15123000, 15123000
. : milestone, 15123000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~2cf109274c, baseline=1.51.1-SNAPSHOT~90125aff77
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.61 ms) : 3394, 3826
. : milestone, 3610,
iast (2.189 ms) : 2126, 2251
. : milestone, 2189,
iast_GLOBAL (2.23 ms) : 2167, 2293
. : milestone, 2230,
profiling (2.053 ms) : 2001, 2105
. : milestone, 2053,
tracing (2.006 ms) : 1957, 2054
. : milestone, 2006,
section candidate
no_agent (1.47 ms) : 1459, 1482
. : milestone, 1470,
appsec (3.644 ms) : 3428, 3861
. : milestone, 3644,
iast (2.187 ms) : 2125, 2249
. : milestone, 2187,
iast_GLOBAL (2.236 ms) : 2173, 2299
. : milestone, 2236,
profiling (2.054 ms) : 2003, 2106
. : milestone, 2054,
tracing (2.007 ms) : 1959, 2055
. : milestone, 2007,
|
if (operator.equals("exists")) { | ||
return false; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥜 Nitpick: Why? The language always exists
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that this doesn't really makes sense from a semantics POV, but it was already like this before and I didn't want to have to change existing behaviours
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can change this in another PR. I don't see much of a use case anyway for this lol
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
internal-api/src/main/java/datadog/trace/bootstrap/config/provider/StableConfigParser.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only did a quick review without the full context according the time sensitive request
internal-api/src/main/java/datadog/trace/bootstrap/config/provider/StableConfigParser.java
Outdated
Show resolved
Hide resolved
internal-api/src/main/java/datadog/trace/bootstrap/config/provider/StableConfigParser.java
Outdated
Show resolved
Hide resolved
internal-api/src/main/java/datadog/trace/bootstrap/config/provider/StableConfigParser.java
Outdated
Show resolved
Hide resolved
internal-api/src/main/java/datadog/trace/bootstrap/config/provider/StableConfigParser.java
Outdated
Show resolved
Hide resolved
switch (operator) { | ||
case "equals": | ||
return value.equals(match); | ||
case "starts_with": | ||
return value.startsWith(match); | ||
case "ends_with": | ||
return value.endsWith(match); | ||
case "contains": | ||
return value.contains(match); | ||
default: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we use method reference here and loop on the matches with instead?
internal-api/src/main/java/datadog/trace/bootstrap/config/provider/StableConfigParser.java
Outdated
Show resolved
Hide resolved
internal-api/src/main/java/datadog/trace/bootstrap/config/provider/StableConfigParser.java
Outdated
Show resolved
Hide resolved
internal-api/src/main/java/datadog/trace/bootstrap/config/provider/StableConfigParser.java
Outdated
Show resolved
Hide resolved
then: | ||
if (filePath == null) { | ||
throw new AssertionError("Failed to create: " + filePath) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files.createTempFile
never returns null
.
If the YAML is constant, store it in test resources instead.
…ider/StableConfigParser.java Co-authored-by: Bruce Bujon <[email protected]>
Given that the test failures here being resolved in #9218 and there is consensus on the urgency to merge, I'm going to bypass rules and admin merge |
* feat: match stable config java properties on other operator than 'contains' * fix: lowercase match value * fix: extra parameter * fix: remove duplicate values * fix: lint * fi: wrong variable * fix lint * fix: tests * fix: null matches with exist should work * feat: add tests for equal operator on arguments * fix: use equal method instead of operator * Update internal-api/src/main/java/datadog/trace/bootstrap/config/provider/StableConfigParser.java Co-authored-by: Bruce Bujon <[email protected]> * apply PR suggestions * fix typo * Add missing locale * add matches == null check back in to avoid NPE --------- Co-authored-by: Mikayla Toffler <[email protected]> Co-authored-by: Bruce Bujon <[email protected]> Co-authored-by: Mikayla Toffler <[email protected]>
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [redis.clients:jedis](https://github.com/redis/jedis) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.0.0` -> `6.1.0` | | [com.google.api.grpc:proto-google-common-protos](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.59.2` -> `2.60.0` | | [com.google.cloud:google-cloud-core-http](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.58.2` -> `2.59.0` | | [com.google.cloud:google-cloud-core](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.58.2` -> `2.59.0` | | [com.google.api:gax](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.68.2` -> `2.69.0` | | [com.squareup.wire](https://github.com/square/wire) | plugin | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-schema](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-runtime](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-reflector](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-moshi-adapter](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-grpc-client](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-bom](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.51.2` -> `1.52.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:regions](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | --- ### Release Notes <details> <summary>redis/jedis (redis.clients:jedis)</summary> ### [`v6.1.0`](https://github.com/redis/jedis/releases/tag/v6.1.0): 6.1.0 ### Changes #### 🚀 New Features - Add support for SVS-VAMANA vector indexing ([#​4222](redis/jedis#4222)) - Clarify why new stream entries aren't deleted with XDELEX ([#​4218](redis/jedis#4218)) - Add support for new stream commands ([#​4211](redis/jedis#4211)) - Add Support for New BITOP Operations in Redis 8.2 ([#​4188](redis/jedis#4188)) ([#​4190](redis/jedis#4190)) - Add binary stream support for XREAD and XREADGROUP ([#​3566](redis/jedis#3566)) ([#​4152](redis/jedis#4152)) - Run pipeline in current thread if all the keys on same node ([#​4149](redis/jedis#4149)) #### 🐛 Bug Fixes - Restore binary compatibility of SetParams ([#​4225](redis/jedis#4225)) - Fix memory leak in JedisClusterInfoCache - replica nodes not cleared ([#​4205](redis/jedis#4205)) - Fix:JedisCluster throws NullPointerException when maxAttempts is set to 0 ([#​4186](redis/jedis#4186)) #### 🧰 Maintenance - DOC-5471 time series doc examples ([#​4210](redis/jedis#4210)) - Bump jackson.version from 2.19.1 to 2.19.2 ([#​4208](redis/jedis#4208)) - Fix flaky test ClientCommandsTest.killSkipmeYesNo ([#​4206](redis/jedis#4206)) - Bump org.junit:junit-bom from 5.13.2 to 5.13.3 ([#​4198](redis/jedis#4198)) - Migrate publishing to Maven Central Portal ([#​4199](redis/jedis#4199)) - Bump org.apache.maven.plugins:maven-gpg-plugin from 3.2.7 to 3.2.8 ([#​4197](redis/jedis#4197)) - Bump org.junit:junit-bom from 5.13.1 to 5.13.2 ([#​4192](redis/jedis#4192)) - DOC-5227 added probabilistic data type examples ([#​4184](redis/jedis#4184)) - Bump jackson.version from 2.19.0 to 2.19.1 ([#​4180](redis/jedis#4180)) - Update test infra to use latest Redis ([#​4179](redis/jedis#4179)) - Bump org.junit:junit-bom from 5.13.0-RC1 to 5.13.1 ([#​4174](redis/jedis#4174)) - Bump org.json:json from [`2025010`](redis/jedis@20250107) to [`2025051`](redis/jedis@20250517) ([#​4171](redis/jedis#4171)) - Bump org.apache.httpcomponents.client5:httpclient5-fluent from 5.4.4 to 5.5 ([#​4170](redis/jedis#4170)) - Fix flaky tests in DocumentTest ([#​3617](redis/jedis#3617)) - Add retryable command execution example ([#​3780](redis/jedis#3780)) - Bump jackson.version from 2.18.3 to 2.19.0 ([#​4160](redis/jedis#4160)) - Bump com.google.code.gson:gson from 2.12.1 to 2.13.1 ([#​4161](redis/jedis#4161)) #### Contributors We'd like to thank all the contributors who worked on this release! [@​219sansim](https://github.com/219sansim), [@​YoHanKi](https://github.com/YoHanKi), [@​andy-stark-redis](https://github.com/andy-stark-redis), [@​ggivo](https://github.com/ggivo), [@​jujn](https://github.com/jujn), [@​thachlp](https://github.com/thachlp), [@​uglide](https://github.com/uglide) and [@​xrayw](https://github.com/xrayw) </details> <details> <summary>googleapis/sdk-platform-java (com.google.api.grpc:proto-google-common-protos)</summary> ### [`v2.60.0`](https://github.com/googleapis/sdk-platform-java/blob/HEAD/CHANGELOG.md#2600-2025-06-23) ##### Features - handle auto pagination for BigQuery v2 ([#​3829](googleapis/sdk-platform-java#3829)) ([025c84c](googleapis/sdk-platform-java@025c84c)) ##### Dependencies - update google auth library dependencies to v1.37.1 ([#​3846](googleapis/sdk-platform-java#3846)) ([ea1d9e5](googleapis/sdk-platform-java@ea1d9e5)) - update google http client dependencies to v1.47.1 ([#​3848](googleapis/sdk-platform-java#3848)) ([a9a39d7](googleapis/sdk-platform-java@a9a39d7)) </details> <details> <summary>square/wire (com.squareup.wire)</summary> ### [`v5.3.6`](https://github.com/square/wire/blob/HEAD/CHANGELOG.md#Version-536) [Compare Source](square/wire@5.3.5...5.3.6) *2025-08-05* ##### CLI - New CLI option `--ignore_unused_roots_and_prunes` ([#​3354](square/wire#3354)) ##### JVM - Fix: Handle negative hexadecimal in default values ([#​3355](square/wire#3355)) - Optimization: Avoid copying of repeated and map types when mutableTypes are being used ([#​3352](square/wire#3352) by \[Rahul Ravikumar]\[tikurahul]) ##### Swift - Fix: Properly disambiguate OneOf enum if it has the same name as enclosing type ([#​3350](square/wire#3350) by \[Dimitris Koutsogiorgas]\[dnkoutso]) </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.52.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.52.0): 1.52.0 ### Components #### Application Security Management (WAF) - ✨ Only report ASM\_DD, ASM\_DATA and ASM capabilities when AppSec is enabled ([#​9260](DataDog/dd-trace-java#9260) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛 Fix NPE in AppSecConfigServiceImpl ([#​9165](DataDog/dd-trace-java#9165) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛 Fix AppSec play.mvc.StatusHeader instrumentation for play 2.6 ([#​9160](DataDog/dd-trace-java#9160) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### Build & Tooling - ✨📖 Automatically register crashtracking via native extensions ([#​8851](DataDog/dd-trace-java#8851) - [@​MattAlp](https://github.com/MattAlp)) #### Configuration at Runtime - ✨ Create activation origin config for telemetry ([#​9064](DataDog/dd-trace-java#9064) - [@​sezen-datadog](https://github.com/sezen-datadog)) #### Continuous Integration Visibility - ✨ Update GitLab provided tags ([#​9275](DataDog/dd-trace-java#9275) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - 🐛 Fix base branch SHA usage in GitHub Actions ([#​9257](DataDog/dd-trace-java#9257) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add `ci.job.id` tag ([#​9256](DataDog/dd-trace-java#9256) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add new org to Weaver instrumentation ([#​9235](DataDog/dd-trace-java#9235) - [@​daniel-mohedano](https://github.com/daniel-mohedano) - thanks for the contribution!) - ✨ Improve Git commit info building ([#​9210](DataDog/dd-trace-java#9210) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Update Attempt to Fix to v5 ([#​9145](DataDog/dd-trace-java#9145) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) #### Crash tracking - ✨📖 Automatically register crashtracking via native extensions ([#​8851](DataDog/dd-trace-java#8851) - [@​MattAlp](https://github.com/MattAlp)) #### Data Streams Monitoring - ✨ Reduce DSM CPU overheard ([#​9151](DataDog/dd-trace-java#9151) - [@​kr-igor](https://github.com/kr-igor)) - ✨⚡ DSM optimizations for high throughput scenarios ([#​9137](DataDog/dd-trace-java#9137) - [@​kr-igor](https://github.com/kr-igor)) #### Database Monitoring - 🐛 Fix duplicate trace injection for SQL Server and Oracle DBM full propagation mode ([#​9224](DataDog/dd-trace-java#9224) - [@​lu-zhengda](https://github.com/lu-zhengda)) #### Dynamic Instrumentation - 🐛 Add URI in string primitives ([#​9285](DataDog/dd-trace-java#9285) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Increase SourceFile tracking max queue size ([#​9271](DataDog/dd-trace-java#9271) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Add capping on SourceFile tracking queue ([#​9245](DataDog/dd-trace-java#9245) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Add third-party filtering in SourceFile tracking ([#​9205](DataDog/dd-trace-java#9205) - [@​jpbempel](https://github.com/jpbempel)) #### ML Observability (LLMObs) - ✨ Add methods to capture embedding and retrieval spans ([#​9297](DataDog/dd-trace-java#9297) - [@​nayeem-kamal](https://github.com/nayeem-kamal)) #### Metrics - ✨ Change primary client stats configuration key ([#​9196](DataDog/dd-trace-java#9196) - [@​amarziali](https://github.com/amarziali)) - ✨ Calculate client stats also if the span kind is eligible ([#​9157](DataDog/dd-trace-java#9157) - [@​amarziali](https://github.com/amarziali)) - ✨ Backpropagate peer tags ([#​9144](DataDog/dd-trace-java#9144) - [@​bric3](https://github.com/bric3)) - 🐛 Make client stats reliable in case of downgrade ([#​9136](DataDog/dd-trace-java#9136) - [@​amarziali](https://github.com/amarziali)) #### Platform components - 🐛 Fix VM options parsing from /proc/fs ([#​9255](DataDog/dd-trace-java#9255) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) #### Profiling - ✨ Switch profile compression to zstd default ([#​9293](DataDog/dd-trace-java#9293) - [@​jbachorik](https://github.com/jbachorik)) - ✨ Bump ddprof to 1.29.0 ([#​9262](DataDog/dd-trace-java#9262) - [@​zhengyu123](https://github.com/zhengyu123)) - Potential memory leak and race with the JVMTI wallclock sampler by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#234 - Downport async-profiler no-allocation changes by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#245 - Adopt openjdk safefetch by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#246 - Safe fetch 64-bit value and pointer by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#247 - Rebase on Async-Profiler 4.1 by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#252 - Patch upstream stackWalker.cpp not to fail on unaligned access by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#218 - Remap thread id to avoid bitmap contention by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#229 - Improve performance using Unsafe to activate/deactivate thread filter by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#230 - Unify context propagation by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#231 - 🐛 Fix the profiler stackdepth setting propagation in recent (22+) Java versions ([#​9130](DataDog/dd-trace-java#9130) - [@​jbachorik](https://github.com/jbachorik)) #### Realtime User Monitoring - ✨ Wrap servlet original PrintWriter on rum injector ([#​9146](DataDog/dd-trace-java#9146) - [@​amarziali](https://github.com/amarziali)) #### Telemetry - ✨ Create activation origin config for telemetry ([#​9064](DataDog/dd-trace-java#9064) - [@​sezen-datadog](https://github.com/sezen-datadog)) #### Tracer core - ✨⚡ Reduce span construction overhead by switching to optimized TagMap ([#​8589](DataDog/dd-trace-java#8589) - [@​dougqh](https://github.com/dougqh)) - 🐛 Match Hands Off Config selectors on process\_arguments value ([#​9201](DataDog/dd-trace-java#9201) - [@​paullegranddc](https://github.com/paullegranddc)) - ✨ Move JSON generation to sender thread to improve startup time. ([#​9197](DataDog/dd-trace-java#9197) - [@​AlexeyKuznetsov-DD](https://github.com/AlexeyKuznetsov-DD)) - ✨ Improve agent to avoid loading global config on main thread ([#​9190](DataDog/dd-trace-java#9190) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ add injection metadata fields to telemetry forwarder ([#​9185](DataDog/dd-trace-java#9185) - [@​sydney-tung](https://github.com/sydney-tung)) - 🐛 Avoid race conditions on feature discovery during Writer creation ([#​9173](DataDog/dd-trace-java#9173) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Surface potential root cause when agent initialization errors ([#​9170](DataDog/dd-trace-java#9170) - [@​AlexeyKuznetsov-DD](https://github.com/AlexeyKuznetsov-DD)) - 💡 Support adding W3C baggage as span tags ([#​9169](DataDog/dd-trace-java#9169) - [@​rachelyangdog](https://github.com/rachelyangdog)) - ✨⚡ Align our default classloader excludes with OTel ([#​9161](DataDog/dd-trace-java#9161) - [@​mcculls](https://github.com/mcculls)) - ✨ Backpropagate container tags hash coming from the info endpoint ([#​9156](DataDog/dd-trace-java#9156) - [@​amarziali](https://github.com/amarziali)) - 🐛 Avoid race conditions and multiple agent discovery feature states ([#​9135](DataDog/dd-trace-java#9135) - [@​amarziali](https://github.com/amarziali)) ### Instrumentations #### AWS SDK instrumentation - ✨ Enhance Service Representation for Serverless ([#​9203](DataDog/dd-trace-java#9203) - [@​zarirhamza](https://github.com/zarirhamza)) #### gRPC instrumentation - 🐛 Add check to prevent injection of repeated GRPC headers ([#​9246](DataDog/dd-trace-java#9246) - [@​mhlidd](https://github.com/mhlidd)) #### JDBC instrumentation - 🐛 Fix duplicate trace injection for SQL Server and Oracle DBM full propagation mode ([#​9224](DataDog/dd-trace-java#9224) - [@​lu-zhengda](https://github.com/lu-zhengda)) #### Play Framework instrumentation - 🐛 Fix AppSec play.mvc.StatusHeader instrumentation for play 2.6 ([#​9160](DataDog/dd-trace-java#9160) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 9da36329ffa552291a640381780b608ef6513e29
What Does This Do
Updates Hands Off Configs Phase 2 to match on process argument values. Previously, we only matched on process argument keys.
For example, a process running with
-Darg1=my-custom-value
will now get service namemy-custom-value
with the following config:Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]