Skip to content

[Console] Handle hidden "process" with --option without = on ConsoleApplication #7022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 26, 2025

Conversation

samsonasik
Copy link
Member

Per #6876 (comment)

@TomasVotruba @shakaran this is to handle without =:

Before

➜  rector-src git:(main) ./bin/rector --kaizen 5

  Command "5" is not defined.  

After

➜  rector-src git:(handle-hidden-process) ./bin/rector --kaizen 5           
[EXPERIMENTAL] Running Kaizen mode. Only first 5 rules will be applied


                                                                                                                        
 [OK] Rector is done!                                                                                                   

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba self-requested a review June 26, 2025 15:09
@TomasVotruba
Copy link
Member

@samsonasik Thank you 👍

Could you also add simple CI 1-line test in the Github workflows that this works with "="?

@samsonasik samsonasik force-pushed the handle-hidden-process branch from bcbfa15 to 7886eb7 Compare June 26, 2025 15:28
@samsonasik
Copy link
Member Author

@TomasVotruba sure, I added various e2e test for it 👍 7886eb7

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready.

@TomasVotruba TomasVotruba merged commit 9e92922 into main Jun 26, 2025
46 checks passed
@TomasVotruba TomasVotruba deleted the handle-hidden-process branch June 26, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants