[Console] Handle hidden "process" with --option without = on ConsoleApplication (#7022)

* [Console] Handle hidden "process" with --option without = on ConsoleApplication

* [ci-review] Rector Rectify

* final touch: ensure verify has parameter option

* final touch: ensure verify has parameter option

* Add CI test for command with vs without process with = and not

* move to specific yaml file

* sync with other e2e

* sync with other e2e

* add test with php prefix

* final touch: eol

* less output

* less output

* with php prefix

* reduce time for only configured test

---------

Co-authored-by: GitHub Action <[email protected]>

Author: samsonasik

.github/workflows/e2e_command_with_option.yaml

@@ -0,0 +1,62 @@
+name: End to End tests command with option
+
+on:
+    pull_request:
+        branches:
+            - main
+    push:
+        branches:
+            - main
+env:
+    # see https://github.com/composer/composer/issues/9368#issuecomment-718112361
+    COMPOSER_ROOT_VERSION: "dev-main"
+
+jobs:
+    code_analysis:
+        strategy:
+            fail-fast: false
+
+        name: End to End tests command with option
+        runs-on: ubuntu-latest
+        timeout-minutes: 10
+
+        steps:
+            -   uses: actions/checkout@v4
+
+            # see https://github.com/shivammathur/setup-php
+            -
+                uses: shivammathur/setup-php@v2
+                with:
+                    php-version: 8.2
+                    coverage: none
+
+            -   uses: "ramsey/composer-install@v3"
+
+            # test various commands with options
+            -   working-directory: e2e/command-with-option
+                run: |
+                    # other command
+                    ../../bin/rector help
+                    php ../../bin/rector help
+
+                    # with explicit "process" command
+                    ../../bin/rector process --kaizen 1 --dry-run
+                    ../../bin/rector process --kaizen=1 --dry-run
+                    php ../../bin/rector process --kaizen 1 --dry-run
+                    php ../../bin/rector process --kaizen=1 --dry-run
+                    ../../bin/rector process some_file.php --kaizen 1
+                    ../../bin/rector process some_file.php --kaizen=1
+                    php ../../bin/rector process some_file.php --kaizen 1
+                    php ../../bin/rector process some_file.php --kaizen=1
+
+                    # with implicit process command
+                    ../../bin/rector --kaizen 1 --dry-run
+                    ../../bin/rector --kaizen=1 --dry-run
+                    php ../../bin/rector --kaizen 1 --dry-run
+                    php ../../bin/rector --kaizen=1 --dry-run
+
+                    ../../bin/rector some_file.php --kaizen 1
+                    ../../bin/rector some_file.php --kaizen=1
+                    php ../../bin/rector some_file.php --kaizen 1
+                    php ../../bin/rector some_file.php --kaizen=1
+

e2e/command-with-option/rector.php

@@ -0,0 +1,16 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\DeadCode\Rector\ConstFetch\RemovePhpVersionIdCheckRector;
+use Rector\Php55\Rector\String_\StringClassNameToClassConstantRector;
+
+return RectorConfig::configure()
+    ->withPaths([
+        __DIR__ . '/some_file.php'
+    ])
+    ->withRules([
+        StringClassNameToClassConstantRector::class,
+        RemovePhpVersionIdCheckRector::class,
+    ]);

e2e/command-with-option/some_file.php

@@ -0,0 +1,5 @@
+<?php
+
+declare(strict_types=1);
+
+echo "some content";

src/Console/ConsoleApplication.php

@@ -64,13 +64,23 @@ public function doRun(InputInterface $input, OutputInterface $output): int
 
         $commandName = $input->getFirstArgument();
 
-        // if paths exist
-        if (is_string($commandName) && file_exists($commandName)) {
+        // if paths exist or if the command name is not the first argument but with --option, eg:
+        // bin/rector src
+        // bin/rector --only "RemovePhpVersionIdCheckRector"
+        // file_exists() can check directory and file
+        if (is_string($commandName)
+            && (
+                file_exists($commandName)
+                || isset($_SERVER['argv'][1])
+                    && $commandName !== $_SERVER['argv'][1]
+                    // ensure verify has parameter option, eg: --only
+                    && $input->hasParameterOption($_SERVER['argv'][1])
+            )
+        ) {
             // prepend command name if implicit
             $privatesAccessor = new PrivatesAccessor();
             $tokens = $privatesAccessor->getPrivateProperty($input, 'tokens');
             $tokens = array_merge(['process'], $tokens);
-
             $privatesAccessor->setPrivateProperty($input, 'tokens', $tokens);
         }