fix: regression in header case-insensitivity #21
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression that was introduced in the recent header case-insensitivity work (Kong#178) that is causing edge cases where, on certain targets, it's possible for a header to be:
multipart/form-datarequests where one header would just bemultipart/form-datawhile the other would be that plus theboundary.undefinedheader being set, being set in ways that it shouldn't be, or the target completely failing to function because a header wasn't being removed.To resolve this I've:
headershelper with a couple methods to traverse the now case-insensitive object of headers so that these targets that need special case handling for something likecontent-typecan safely search for that in the available headers.For testing all of this, I've updated the
multipart/form-datatest fixture to have itscontent-typeheader asContent-Typeto force this case-insensitive lookup for targets that need it.😰