-
Notifications
You must be signed in to change notification settings - Fork 240
fix: don't convert header names to lowercase #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't convert header names to lowercase #178
Conversation
bfab905 to
b5e1039
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finishing this off!
Do you have any thoughts about whether handling headers with HTTP/1.1 (case-insensitive) vs HTTP/2 (case-sensitive) is the responsibility of this library, or responsibility of the consumer? (cc: @darrenjennings)
I am impartial, but since we have access to the version on the HAR object, we might as well follow the RFC.
b5e1039 to
4076e96
Compare
develohpanda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, nice to see an additional unit test! 👍
Just a minor comment on the use of regex
4076e96 to
958b1e0
Compare
develohpanda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done 🙌
|
released in 1.23.0 |
|
This change has unfortunately introduced some header duping in some cases of commonly used headers like I'm working on a PR right now though. |
I've completed @darrenjennings branch to remove the
.toLowerCasefor header names.Closes #74