Skip to content

Conversation

@clue
Copy link
Member

@clue clue commented Jan 31, 2021

This changeset adds PHP 8 support and support for socket pair descriptors.

The socket pair descriptors are supported as of PHP 8 and provide native, non-blocking I/O support on Windows without any fancy workarounds. The PHP documentation doesn't currently reflect this features, but it's available in the upgrade guide here: https://www.php.net/manual/en/migration80.new-features.php

This changeset includes relevant tests, documentation and examples. In a follow-up PR I'll look into making socket pair descriptors the default for Windows, to make sure this works out-of-the-box on any platform. Explicit configuration will always remain available.

Builds on top of #84, #82, #67 and #65

@clue
Copy link
Member Author

clue commented Jan 31, 2021

Updated to work around legacy HHVM which doesn't report pipe open mode. All tests pass now, so this is ready for review :shipit:

@clue clue requested review from WyriHaximus and jsor January 31, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants