Skip to content

Conversation

@SimonFrings
Copy link
Member

@SimonFrings SimonFrings commented Jan 25, 2021

PHPUnit 9.3 released a new schema for the phpunit.xml configuration file. I had to migrate the file to the new format in order to avoid the warning. PHPUnit Versions older than 9.3 have to use the phpunit.xml.legacy configuration file because the new format is unknown for them.
For further details concerning this pull request look into graphp/graphviz #46.

It's also possible to run this code with PHP 8 (without extension) 🎉

$ docker run -it --rm -v `pwd`:/data --workdir=/data php:8.0.0 php vendor/bin/phpunit
PHPUnit 9.5.1 by Sebastian Bergmann and contributors.

..SSSSSSSSSSSSSSSSSSSSSSSSSSSS.SSSS..SSSSSSSSSSSSSSSSSSSSSSSSSS  63 / 140 ( 45%)
SS.SSSS..SSSSSSSSSSSSSSSSSSSSSSSSSSSS.SSSS..................... 126 / 140 ( 90%)
...........SS.                                                  140 / 140 (100%)

Time: 00:05.394, Memory: 450.01 MB

OK, but incomplete, skipped, or risky tests!
Tests: 140, Assertions: 88, Skipped: 98.

Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update, changes LGTM! :shipit:

As soon as this one and reactphp/reactphp#442 is merged, I'll build on top of this and migrate this repository to GitHub Actions with full PHP 8 support 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants