Skip to content

[docs] Add antipattern for nested ray.get #43184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 2, 2025

Conversation

stephanie-wang
Copy link
Contributor

Why are these changes needed?

Add antipattern for nested ray.get, which should be avoided if the ObjectRefs can be passed as direct task args instead.

Signed-off-by: Stephanie Wang <[email protected]>
@stephanie-wang stephanie-wang requested a review from a team as a code owner February 15, 2024 00:53
stephanie-wang and others added 2 commits February 20, 2024 22:09
Co-authored-by: angelinalg <[email protected]>
Signed-off-by: Stephanie Wang <[email protected]>
Co-authored-by: angelinalg <[email protected]>
Signed-off-by: Stephanie Wang <[email protected]>
Copy link

stale bot commented Apr 26, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Apr 26, 2025
@jjyao jjyao added go add ONLY when ready to merge, run all tests and removed stale The issue is stale. It will be closed within 7 days unless there are further conversation labels Apr 28, 2025
@jjyao
Copy link
Collaborator

jjyao commented Apr 30, 2025

/ray/doc/source/ray-core/patterns/nested-ray-get.rst:24: WARNING: unknown document: 'task-pattern-nested-tasks'

Copy link

github-actions bot commented Jun 2, 2025

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@github-actions github-actions bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Jun 2, 2025
@jjyao jjyao merged commit 6475f11 into ray-project:master Jun 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests stale The issue is stale. It will be closed within 7 days unless there are further conversation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants