-
Notifications
You must be signed in to change notification settings - Fork 673
RainbowToasts #6744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
natew
wants to merge
139
commits into
develop
Choose a base branch
from
nate/toasts
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
RainbowToasts #6744
+1,937
−235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/testflight |
# This is the 1st commit message: implementing content styling # This is the commit message #2:
* fix * . * oops
* Fix and run wallet connect test * Improve google sign in in e2e tests
…sk, improve expanded toast after content display
…6753) * calc bottom inset w/ screen height vs window height * restore test
4866774
to
ca14cf7
Compare
2199967
to
da57d59
Compare
0a49f52
to
f69927c
Compare
ibrahimtaveras00
approved these changes
Aug 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All issues have been resolved, QA Passed 👍🏽
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-2818
What changed (plus any additional context for devs)
Added a new toast and expanded toast for Swap, Send, and Mint.
Screen recordings / screenshots
Note the right side of the expanded toast in real transactions should show properly formatted information just like how it's shown in the ActivityList, the dev helpers don't have that data to show:
CleanShot.2025-07-16.at.10.02.09.mp4
(Slight bug on one interaction here I fixed):
CleanShot.2025-07-16.at.09.26.13.mp4
Stacking:
What to test
I've added "Rainbow Toasts" feature flag so you'll need to enable that.