Fix and run wallet connect test #6741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janicduplessis
force-pushed
the
@janic/test-ci
branch
from
6fc14a0 to
1721ade
Compare
BrodyHughes
approved these changes
Jul 10, 2025
|
Some other tests seem to still be failing but this one passed so should be good |
natew
pushed a commit
that referenced
this pull request
Jul 16, 2025
* Fix and run wallet connect test * Improve google sign in in e2e tests
jinchung
pushed a commit
that referenced
this pull request
Aug 25, 2025
* new toasts - start with basic structure rendering * somewhat working pan responder and dismiss organize * # This is a combination of 2 commits. # This is the 1st commit message: implementing content styling # This is the commit message #2: * implementing content styling * add mint contents * make it easier to test * fix keychain reset not resetting wallet state (#6740) * bump iOS and Android to v1.9.72 (#6742) * Run e2e tests on develop (#6743) * [FIX] ios e2e Discover test failing (#6746) * fix * . * oops * Improve google sign in in e2e tests (#6747) * fix (#6748) * Fix and run wallet connect test (#6741) * Fix and run wallet connect test * Improve google sign in in e2e tests * improve dev toasts using real data, fix swap toast display and add mask, improve expanded toast after content display * lots of cleanup and fixing toasts, improve mock data * polish and cleanup * loading states and pointer events fixes * bug * remove logs * imports * code cleanup * [e2e fix] calculate bottom inset w/ screen height vs window height (#6753) * calc bottom inset w/ screen height vs window height * restore test * cleanup visuals on light mode, auto hide itself after finish * android fixes and last bugs * add mint pending status logic * cleanup * more cleanup and improve animations * account for starting from below * naming * improve mints * semirounded mint success * improve swap text expanded after spacing and ellipsizing, improve android backdrop * resolve feedback * organize and improve transaction watching * cleanup * avoid opening activity list on send * persist toast state and avoid memory accumulation * remove logs * ensure we always remove toast in case pending gets stuck * cleanup * fix test overflow issue, fix dev action reset * fix toast icons android * feedback * more feedback fixes * handle more dapp transaction types * simulator conditional logic, add worklets * add worklets to expanded toast * fix types due to improved type fix feedback * resolve * fix simulator and add stylesheets seperate * fix loading state for contract toasts expanded * fix android icons to match ios * handle width changing on toasts, move toasts debug actions into developer sheet * improve timings, thresholds, widths * account for emulator in swipe dismiss threshold * support all the other transaction types * merge * commit changed sha mostly so i can ask why this happens * improve keeping existing name while moving through statuses * cleanup * cleanup * cleanup * better handling of transaction labels expanded * fix worklet * cleanup * more cleanup * cleanup sf symbol icon * make edge case of success => open => dismisses while open not happen * improve touch cancel * fine tune spacing * use figma color * fine tune * fix light mode * feedback on gradient * add flag and fix typo in function * add toast flag and enable in dev/testflight * remove unused * add some friction on pulling down toast expanded panel * make exiting toast expanded content settle even faster * improve some naming, fix contract fail state * improve displacement value (was stuck on hmr before) * avoid showing "Confirmed" for swap/send, instead show Swapped/Sent * fix labels for many types of transactions * fix image of send display and add network icon * add send nft mock and fix display * add speedup mock data and flow * fix confirm types and better handle changing types * lints * fix type * fix sale * add shimmer when pending state * nicer width animations, text ellipsis, example launch, nicer debug logs * cleanups for android press interactions getting conflicted * lint * remove unused file * Toast improvements (#6799) * Toast improvements * Fix cancel case * Remove iOS emulator logic * Better way to stabilize transactions for toasts * Fix cut off text, don't display chain icon when mainnet * Fixes * Toasts - improved dismiss gestures (#6783) * toasts: add useVerticalDismissPanGesture and share between expanded and small toasts for pull and push to dismiss * Fixes * Simplify * Remove android hacks * Cleanup --------- Co-authored-by: Janic Duplessis <[email protected]> * Remove debug sheet, unused import * More cleanup * Fixes * Bring back amount * Remove last isMocked usage * Dismiss toasts on wallet change * Handle more navigate to transactions cases * Store toasts as a map + sorted ids * Fix e2e tests * Fix send amount, sort toasts by updatedAt * Don't create toasts when tx is not pending * Improve send display, fix e2e tests * Fix e2e test * Fix ios e2e test * Make input wrapper not accessible to fix tests * Reimplement toasts state * Swap and launch fixes + misc cleanups * Refactor some methods to helpers/transactions.ts * Fix new mined transactions * Fixes * Pull in fix from balances PR --------- Co-authored-by: Ibrahim Taveras <[email protected]> Co-authored-by: Janic Duplessis <[email protected]> Co-authored-by: brdy <[email protected]>
ibrahimtaveras00
added a commit
that referenced
this pull request
Aug 25, 2025
* new toasts - start with basic structure rendering * somewhat working pan responder and dismiss organize * # This is a combination of 2 commits. # This is the 1st commit message: implementing content styling # This is the commit message #2: * implementing content styling * add mint contents * make it easier to test * fix keychain reset not resetting wallet state (#6740) * bump iOS and Android to v1.9.72 (#6742) * Run e2e tests on develop (#6743) * [FIX] ios e2e Discover test failing (#6746) * fix * . * oops * Improve google sign in in e2e tests (#6747) * fix (#6748) * Fix and run wallet connect test (#6741) * Fix and run wallet connect test * Improve google sign in in e2e tests * improve dev toasts using real data, fix swap toast display and add mask, improve expanded toast after content display * lots of cleanup and fixing toasts, improve mock data * polish and cleanup * loading states and pointer events fixes * bug * remove logs * imports * code cleanup * [e2e fix] calculate bottom inset w/ screen height vs window height (#6753) * calc bottom inset w/ screen height vs window height * restore test * cleanup visuals on light mode, auto hide itself after finish * android fixes and last bugs * add mint pending status logic * cleanup * more cleanup and improve animations * account for starting from below * naming * improve mints * semirounded mint success * improve swap text expanded after spacing and ellipsizing, improve android backdrop * resolve feedback * organize and improve transaction watching * cleanup * avoid opening activity list on send * persist toast state and avoid memory accumulation * remove logs * ensure we always remove toast in case pending gets stuck * cleanup * fix test overflow issue, fix dev action reset * fix toast icons android * feedback * more feedback fixes * handle more dapp transaction types * simulator conditional logic, add worklets * add worklets to expanded toast * fix types due to improved type fix feedback * resolve * fix simulator and add stylesheets seperate * fix loading state for contract toasts expanded * fix android icons to match ios * handle width changing on toasts, move toasts debug actions into developer sheet * improve timings, thresholds, widths * account for emulator in swipe dismiss threshold * support all the other transaction types * merge * commit changed sha mostly so i can ask why this happens * improve keeping existing name while moving through statuses * cleanup * cleanup * cleanup * better handling of transaction labels expanded * fix worklet * cleanup * more cleanup * cleanup sf symbol icon * make edge case of success => open => dismisses while open not happen * improve touch cancel * fine tune spacing * use figma color * fine tune * fix light mode * feedback on gradient * add flag and fix typo in function * add toast flag and enable in dev/testflight * remove unused * add some friction on pulling down toast expanded panel * make exiting toast expanded content settle even faster * improve some naming, fix contract fail state * improve displacement value (was stuck on hmr before) * avoid showing "Confirmed" for swap/send, instead show Swapped/Sent * fix labels for many types of transactions * fix image of send display and add network icon * add send nft mock and fix display * add speedup mock data and flow * fix confirm types and better handle changing types * lints * fix type * fix sale * add shimmer when pending state * nicer width animations, text ellipsis, example launch, nicer debug logs * cleanups for android press interactions getting conflicted * lint * remove unused file * Toast improvements (#6799) * Toast improvements * Fix cancel case * Remove iOS emulator logic * Better way to stabilize transactions for toasts * Fix cut off text, don't display chain icon when mainnet * Fixes * Toasts - improved dismiss gestures (#6783) * toasts: add useVerticalDismissPanGesture and share between expanded and small toasts for pull and push to dismiss * Fixes * Simplify * Remove android hacks * Cleanup --------- Co-authored-by: Janic Duplessis <[email protected]> * Remove debug sheet, unused import * More cleanup * Fixes * Bring back amount * Remove last isMocked usage * Dismiss toasts on wallet change * Handle more navigate to transactions cases * Store toasts as a map + sorted ids * Fix e2e tests * Fix send amount, sort toasts by updatedAt * Don't create toasts when tx is not pending * Improve send display, fix e2e tests * Fix e2e test * Fix ios e2e test * Make input wrapper not accessible to fix tests * Reimplement toasts state * Swap and launch fixes + misc cleanups * Refactor some methods to helpers/transactions.ts * Fix new mined transactions * Fixes * Pull in fix from balances PR --------- Co-authored-by: Ibrahim Taveras <[email protected]> Co-authored-by: Janic Duplessis <[email protected]> Co-authored-by: brdy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-####
What changed (plus any additional context for devs)
The wallet connect test wasn't currently running because it wasn't in
flows. This fixes it and also make it work on iOS. Maestro can't interact properly with webviews in iOS so skip most of the test.Screen recordings / screenshots
N/A
What to test
Check that WalletConnect test passes on CI