feat(MLOP-2236): add NTZ #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
albjoaov
reviewed
Jun 13, 2024
|
|
||
| def __init__( | ||
| self, | ||
| dtype: Optional[DataType] = DataType.TIMESTAMP, |
There was a problem hiding this comment.
Should be?
Suggested change
| dtype: Optional[DataType] = DataType.TIMESTAMP, | |
| dtype: Optional[DataType] = DataType.TIMESTAMP_NTZ, |
There was a problem hiding this comment.
Hey @albjoaov !! I set TIMESTAMP as default to migrate our feature sets smoothly!
ralphrass
requested review from
albjoaov,
mikaelsouza,
otaviocals,
marcoVinha and
michellyrds
ralphrass
added a commit
that referenced
this pull request
Jun 14, 2024
* feat(MLOP-2236): add NTZ (#360) * feat: NTZ and new tests
lecardozo
pushed a commit
that referenced
this pull request
Feb 18, 2025
🤖 I have created a release *beep* *boop* --- ## [1.5.0](v1.4.8...v1.5.0) (2025-02-18) ### Features * **MLOP-1985:** optional params ([#347](#347)) ([9bcca0e](9bcca0e)) * **MLOP-2145:** add feature set creation script ([#351](#351)) ([688a5b3](688a5b3)) * **MLOP-2236:** add NTZ ([#360](#360)) ([2a5a6e8](2a5a6e8)) * **mlop-2269:** bump versions ([#355](#355)) ([887fbb2](887fbb2)) * **mlop-2455:** add release please workflow ([#398](#398)) ([353a9b5](353a9b5)) * **mlop-2456:** add protection to host setting on cassandra_client ([#385](#385)) ([ab551c0](ab551c0)) * optional row count validation ([#340](#340)) ([2a19009](2a19009)) ### Bug Fixes * Cassandra config keys ([#366](#366)) ([81c2c17](81c2c17)) * cassandra configs ([#364](#364)) ([6363e03](6363e03)) * include extra-files config for version bump ([#400](#400)) ([49c91fa](49c91fa)) * **MLOP-2519:** avoid configuring logger at lib level ([#393](#393)) ([b7c7d48](b7c7d48)) * move incremental filter ([#388](#388)) ([b802f69](b802f69)) * new type ([#368](#368)) ([b1949cd](b1949cd)) * parameter, libs ([#341](#341)) ([ca1a16d](ca1a16d)) * performance adjustments, migrate ([#378](#378)) ([52d4911](52d4911)) * performance improvements ([#374](#374)) ([11cc5d5](11cc5d5)) * publish and dev versions ([#359](#359)) ([cbda73d](cbda73d)) * release-please action runner ([#402](#402)) ([216bd50](216bd50)) * remove unwanted configs for release-please ([#403](#403)) ([b2b554e](b2b554e)) * rollback repartition ([#386](#386)) ([a11a699](a11a699)) * Rollback to latest stable release ([#391](#391)) ([5e6f416](5e6f416)) * sphinx version ([#356](#356)) ([5af8a05](5af8a05)) * version, format ([#376](#376)) ([5f7028b](5f7028b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Feb 18, 2025
albjoaov
added a commit
that referenced
this pull request
Feb 19, 2025
🤖 I have created a release *beep* *boop* --- ## [1.5.0](1.4.7...1.5.0) (2025-02-19) ### Features * **MLOP-1985:** optional params ([#347](#347)) ([9bcca0e](9bcca0e)) * **MLOP-2145:** add feature set creation script ([#351](#351)) ([688a5b3](688a5b3)) * **MLOP-2236:** add NTZ ([#360](#360)) ([2a5a6e8](2a5a6e8)) * **mlop-2269:** bump versions ([#355](#355)) ([887fbb2](887fbb2)) * **mlop-2455:** add release please workflow ([#398](#398)) ([353a9b5](353a9b5)) * **mlop-2456:** add protection to host setting on cassandra_client ([#385](#385)) ([ab551c0](ab551c0)) * optional row count validation ([#340](#340)) ([2a19009](2a19009)) ### Bug Fixes * Cassandra config keys ([#366](#366)) ([81c2c17](81c2c17)) * cassandra configs ([#364](#364)) ([6363e03](6363e03)) * include extra-files config for version bump ([#400](#400)) ([49c91fa](49c91fa)) * **MLOP-2519:** avoid configuring logger at lib level ([#393](#393)) ([b7c7d48](b7c7d48)) * **mlop-2649:** fix release process ([#406](#406)) ([880bc0c](880bc0c)) * move incremental filter ([#388](#388)) ([b802f69](b802f69)) * new type ([#368](#368)) ([b1949cd](b1949cd)) * parameter, libs ([#341](#341)) ([ca1a16d](ca1a16d)) * performance adjustments, migrate ([#378](#378)) ([52d4911](52d4911)) * performance improvements ([#374](#374)) ([11cc5d5](11cc5d5)) * publish and dev versions ([#359](#359)) ([cbda73d](cbda73d)) * release-please action runner ([#402](#402)) ([216bd50](216bd50)) * remove unwanted configs for release-please ([#403](#403)) ([b2b554e](b2b554e)) * rollback repartition ([#386](#386)) ([a11a699](a11a699)) * Rollback to latest stable release ([#391](#391)) ([5e6f416](5e6f416)) * sphinx version ([#356](#356)) ([5af8a05](5af8a05)) * version, format ([#376](#376)) ([5f7028b](5f7028b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: joao.albuquerque <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? 📖
Turn no timezone timestamp available. If one use Butterfree with TimestampFeature it can obtain different values of timestamps due to SO configs, which is bad for time-sensitive feature sets.
What? 🔧
Type of change
Please delete options that are not relevant.
How everything was tested? 📏
Local tests