Skip to content

Commit b802f69

Browse files
authored
fix: move incremental filter (#388)
1 parent a11a699 commit b802f69

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

butterfree/transform/aggregated_feature_set.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -580,10 +580,6 @@ def construct(
580580
for feature in self.keys + [self.timestamp]:
581581
output_df = feature.transform(output_df)
582582

583-
output_df = self.incremental_strategy.filter_with_incremental_strategy(
584-
dataframe=output_df, start_date=start_date, end_date=end_date
585-
)
586-
587583
if self._windows and end_date is not None:
588584
# Run aggregations for each window
589585
agg_list = [
@@ -636,6 +632,10 @@ def construct(
636632
else:
637633
output_df = self._aggregate(output_df, features=self.features)
638634

635+
output_df = self.incremental_strategy.filter_with_incremental_strategy(
636+
dataframe=output_df, start_date=start_date, end_date=end_date
637+
)
638+
639639
output_df = output_df.select(*self.columns).replace( # type: ignore
640640
float("nan"), None
641641
)

0 commit comments

Comments
 (0)