Skip to content

Security doc fix and improved warning message #9673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2020
Merged

Security doc fix and improved warning message #9673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd4a54c
Fix security provider property name #9664
galderz May 29, 2020
0843e47
Provide clues when configuration is unrecognized #9664
galderz May 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/runtime/src/main/java/io/quarkus/runtime/configuration/ConfigDiagnostic.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public static void deprecated(String name) {
}

public static void unknown(String name) {
log.warnf("Unrecognized configuration key \"%s\" was provided; it will be ignored", name);
log.warnf("Unrecognized configuration key \"%s\" was provided; it will be ignored; verify that the dependency extension for this configuration is set or you did not make a typo", name);
}

public static void unknown(NameIterator name) {
Expand All @@ -58,7 +58,7 @@ public static void unknown(NameIterator name) {
public static void unknownRunTime(String name) {
if (ImageInfo.inImageRuntimeCode()) {
// only warn at run time for native images, otherwise the user will get warned twice for every property
log.warnf("Unrecognized configuration key \"%s\" was provided; it will be ignored", name);
log.warnf("Unrecognized configuration key \"%s\" was provided; it will be ignored; verify that the dependency extension for this configuration is set or that you did not make a typo", name);
}
}

Expand Down
2 changes: 1 addition & 1 deletion docs/src/main/asciidoc/security.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ security annotations. Defaults to `false`.

When running in native mode the default behavior for Graal native image generation is to only include the main "SUN" provider
unless you have enabled SSL, in which case all security providers are registered. If you are not using SSL, then you can selectively
register security providers by name using the `quarkus.security.users.security-providers` property. The following example illustrates
register security providers by name using the `quarkus.security.security-providers` property. The following example illustrates
configuration to register the "SunRsaSign" and "SunJCE" security providers:

.Example Security Providers Configuration
Expand Down