Security doc fix and improved warning message #9673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| public static void unknown(String name) { | ||
| log.warnf("Unrecognized configuration key \"%s\" was provided; it will be ignored", name); | ||
| log.warnf("Unrecognized configuration key \"%s\" was provided; it will be ignored; verify that the dependency extension for this configuration is set", name); |
Member
There was a problem hiding this comment.
if you display this, you also should add "or that you did not make a typo".
Member
Author
|
@emmanuelbernard Pushed a fix to improve the message. |
sberyozkin
approved these changes
Jun 3, 2020
Member
There was a problem hiding this comment.
@galderz IMHO it looks good. Small proposal, drop a 2nd that in the message as it has become a bit long for it to become:
...verify that the dependency extension for this configuration is set or you did not make a typo
But it is just a very small thing, cc @gsmet @emmanuelbernard please merge if you are happy with the PR
* Configuration might not be recognized due to missing extension dependencies. * Improve warning message to provide such hint.
Member
Author
|
@sberyozkin Done |
Member
|
@galderz Thanks :-), looks like everyone is happy with your fix so let me merge, cheers |
gsmet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9664