-
Notifications
You must be signed in to change notification settings - Fork 3k
Ensure that an uppercase username doesn't break container-image building #8823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
...st/java/io/quarkus/container/image/deployment/ContainerImageConfigEffectiveGroupTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| package io.quarkus.container.image.deployment; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
|
|
||
| import java.util.Optional; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| class ContainerImageConfigEffectiveGroupTest { | ||
|
|
||
| public static final String USER_NAME_SYSTEM_PROPERTY = "user.name"; | ||
|
|
||
| private ContainerImageConfig sut = new ContainerImageConfig(); | ||
|
|
||
| @Test | ||
| void testFromLowercaseUsername() { | ||
| testWithNewUsername("test", () -> { | ||
| sut.group = Optional.of(System.getProperty(USER_NAME_SYSTEM_PROPERTY)); | ||
| assertEquals(sut.getEffectiveGroup(), Optional.of("test")); | ||
| }); | ||
| } | ||
|
|
||
| @Test | ||
| void testFromUppercaseUsername() { | ||
| testWithNewUsername("TEST", () -> { | ||
| sut.group = Optional.of(System.getProperty(USER_NAME_SYSTEM_PROPERTY)); | ||
| assertEquals(sut.getEffectiveGroup(), Optional.of("test")); | ||
| }); | ||
| } | ||
|
|
||
| @Test | ||
| void testFromOther() { | ||
| testWithNewUsername("WhateveR", () -> { | ||
| sut.group = Optional.of("OtheR"); | ||
| assertEquals(sut.getEffectiveGroup(), Optional.of("OtheR")); | ||
| }); | ||
| } | ||
|
|
||
| private void testWithNewUsername(String newUserName, Runnable test) { | ||
| String previousUsernameValue = System.getProperty(USER_NAME_SYSTEM_PROPERTY); | ||
| System.setProperty(USER_NAME_SYSTEM_PROPERTY, newUserName); | ||
|
|
||
| test.run(); | ||
|
|
||
| System.setProperty(USER_NAME_SYSTEM_PROPERTY, previousUsernameValue); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why we lowercase only in this case? I mean it will fail if the group has some uppercase character, won't it?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My idea is that it's better to fail if the user explicitly sets a group that is invalid (the error message is very explicit and actionable). I am thinking that if we start changing user supplied configuration it could be a very slippery slope...
If however the user did not set anything and the username was used implicitly, then only in that implicit case should we intervene.