Ensure that an uppercase username doesn't break container-image building #8823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
changed the title
gsmet
reviewed
Apr 24, 2020
| if (group.isPresent()) { | ||
| String originalGroup = group.get(); | ||
| if (originalGroup.equals(System.getProperty("user.name"))) { | ||
| return Optional.of(originalGroup.toLowerCase()); |
There was a problem hiding this comment.
I'm not sure why we lowercase only in this case? I mean it will fail if the group has some uppercase character, won't it?
There was a problem hiding this comment.
My idea is that it's better to fail if the user explicitly sets a group that is invalid (the error message is very explicit and actionable). I am thinking that if we start changing user supplied configuration it could be a very slippery slope...
If however the user did not set anything and the username was used implicitly, then only in that implicit case should we intervene.
gsmet
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8819