Skip to content

Sentry tests - getSentryHandler method to reduce duplicated code #5961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2019
Merged

Sentry tests - getSentryHandler method to reduce duplicated code #5961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 2 additions & 22 deletions ...ing-sentry/deployment/src/test/java/io/quarkus/logging/sentry/SentryLoggerCustomTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,14 @@
package io.quarkus.logging.sentry;

import static io.quarkus.logging.sentry.SentryLoggerTest.getSentryHandler;
import static io.sentry.jvmti.ResetFrameCache.resetFrameCache;
import static org.assertj.core.api.Assertions.assertThat;

import java.util.Arrays;
import java.util.logging.Handler;
import java.util.logging.Level;
import java.util.logging.LogManager;
import java.util.logging.Logger;

import org.jboss.logmanager.handlers.DelayedHandler;
import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.RegisterExtension;

import io.quarkus.runtime.logging.InitialConfigurator;
import io.quarkus.test.QuarkusUnitTest;
import io.sentry.jul.SentryHandler;
import io.sentry.jvmti.FrameCache;

public class SentryLoggerCustomTest {
Expand All @@ -27,19 +19,7 @@ public class SentryLoggerCustomTest {

@Test
public void sentryLoggerCustomTest() {
LogManager logManager = LogManager.getLogManager();
assertThat(logManager).isInstanceOf(org.jboss.logmanager.LogManager.class);

DelayedHandler delayedHandler = InitialConfigurator.DELAYED_HANDLER;
assertThat(Logger.getLogger("").getHandlers()).contains(delayedHandler);
assertThat(delayedHandler.getLevel()).isEqualTo(Level.ALL);

Handler handler = Arrays.stream(delayedHandler.getHandlers())
.filter(h -> (h instanceof SentryHandler))
.findFirst().orElse(null);
SentryHandler sentryHandler = (SentryHandler) handler;
assertThat(sentryHandler).isNotNull();
assertThat(sentryHandler.getLevel()).isEqualTo(org.jboss.logmanager.Level.TRACE);
assertThat(getSentryHandler().getLevel()).isEqualTo(org.jboss.logmanager.Level.TRACE);
assertThat(FrameCache.shouldCacheThrowable(new IllegalStateException("Test frame"), 1)).isTrue();
}

Expand Down
8 changes: 6 additions & 2 deletions ...s/logging-sentry/deployment/src/test/java/io/quarkus/logging/sentry/SentryLoggerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ public class SentryLoggerTest {

@Test
public void sentryLoggerDefaultTest() {
assertThat(getSentryHandler().getLevel()).isEqualTo(org.jboss.logmanager.Level.WARN);
assertThat(FrameCache.shouldCacheThrowable(new IllegalStateException("Test frame"), 1)).isFalse();
}

public static SentryHandler getSentryHandler() {
LogManager logManager = LogManager.getLogManager();
assertThat(logManager).isInstanceOf(org.jboss.logmanager.LogManager.class);

Expand All @@ -39,8 +44,7 @@ public void sentryLoggerDefaultTest() {
.findFirst().orElse(null);
SentryHandler sentryHandler = (SentryHandler) handler;
assertThat(sentryHandler).isNotNull();
assertThat(sentryHandler.getLevel()).isEqualTo(org.jboss.logmanager.Level.WARN);
assertThat(FrameCache.shouldCacheThrowable(new IllegalStateException("Test frame"), 1)).isFalse();
return sentryHandler;
}

@AfterAll
Expand Down