Skip to content

Conversation

rsvoboda
Copy link
Member

@rsvoboda rsvoboda commented Dec 5, 2019

Sentry tests - getSentryHandler method to reduce duplicated code

@gsmet
Copy link
Member

gsmet commented Dec 5, 2019

@ia3andy can you have a look?

@gsmet gsmet requested a review from ia3andy December 5, 2019 18:34
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @rsvoboda did you also refactor the other Logger tests which use nearly the same code as well?

@ia3andy ia3andy merged commit 664c312 into quarkusio:master Dec 6, 2019
@rsvoboda
Copy link
Member Author

rsvoboda commented Dec 6, 2019

@ia3andy will double check other logger tests, looked just in sentry ones.

@ia3andy
Copy link
Contributor

ia3andy commented Dec 6, 2019

@rsvoboda have a look in core/test-extension/deployment/src/test.. and in extensions/logging-json/deployement/src/test/...

@gsmet gsmet added this to the 1.1.0 milestone Dec 6, 2019
@rsvoboda rsvoboda deleted the sentry.tests.getSentryHandler branch March 4, 2021 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants