Specify keycloak version in tests #5547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
requested changes
Nov 17, 2019
| <images> | ||
| <image> | ||
| <name>quay.io/keycloak/keycloak</name> | ||
| <name>quay.io/keycloak/keycloak::7.0.1</name> |
stuartwdouglas
force-pushed
the
keycloak-version
branch
from
4977de7 to
536c67c
Compare
gsmet
reviewed
Nov 18, 2019
| <images> | ||
| <image> | ||
| <name>quay.io/keycloak/keycloak</name> | ||
| <name>quay.io/keycloak/keycloak:7.0.1</name> |
There was a problem hiding this comment.
Couldn't we use a centralized property for that? It would have to be in the build-parent pom.xml.
stuartwdouglas
force-pushed
the
keycloak-version
branch
from
536c67c to
f2f83dd
Compare
stuartwdouglas
force-pushed
the
keycloak-version
branch
from
f2f83dd to
2599016
Compare
|
It looks like 60c4d44 removed the fixed version number for keycloak |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.