Skip to content

Conversation

jaikiran
Copy link
Member

@jaikiran jaikiran commented Nov 17, 2019

The commit here temporarily disables the BearerTokenAuthorizationTest since it has been failing consistently in recent runs causing CI failures for other unrleated PRs.

Once the real issue is fixed, this can then be re-enabled.

The PR has now been updated to use 7.0.1 of Keycloak docker image to run these tests, instead of the "latest" which since the past 2 days has now moved to 8.0.0 and has been causing failures in the Keycloak related tests.

@machi1990
Copy link
Member

Thanks @jaikiran. CI seems to be still failing for native test too, can you have a look?

Running io.quarkus.it.keycloak.BearerTokenAuthorizationInGraalITCase
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.872 s <<< FAILURE! - in io.quarkus.it.keycloak.BearerTokenAuthorizationInGraalITCase
[ERROR] io.quarkus.it.keycloak.BearerTokenAuthorizationInGraalITCase  Time elapsed: 0.872 s  <<< ERROR!
java.net.ConnectException: Connection refused (Connection refused)

We'll need to disable it too. Thanks.

@jaikiran
Copy link
Member Author

Interesting. I had thought that since the BearerTokenAuthorizationInGraalITCase was extending this now disabled BearerTokenAuthorizationTest, it would be skipped too. But apparently not.

I've updated this PR to explicitly disable BearerTokenAuthorizationInGraalITCase too.

@jaikiran
Copy link
Member Author

So it now fails for io.quarkus.it.keycloak.CodeFlowTest with the same exception:

java.net.ConnectException: Connection refused (Connection refused)
	at java.net.PlainSocketImpl.socketConnect(Native Method)
	at java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:350)
	at java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206)
	at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188)
	at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
	at java.net.Socket.connect(Socket.java:607)
	at org.apache.http.conn.scheme.PlainSocketFactory.connectSocket(PlainSocketFactory.java:121)
	at org.apache.http.impl.conn.DefaultClientConnectionOperator.openConnection(DefaultClientConnectionOperator.java:180)
	at org.apache.http.impl.conn.ManagedClientConnectionImpl.open(ManagedClientConnectionImpl.java:326)
	at org.apache.http.impl.client.DefaultRequestDirector.tryConnect(DefaultRequestDirector.java:605)
	at org.apache.http.impl.client.DefaultRequestDirector.execute(DefaultRequestDirector.java:440)
	at org.apache.http.impl.client.AbstractHttpClient.doExecute(AbstractHttpClient.java:835)
	at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:83)
	at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:56)
	at org.apache.http.client.HttpClient$execute$0.call(Unknown Source)
	at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:115)
	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:135)
	at io.restassured.internal.RequestSpecificationImpl$RestAssuredHttpBuilder.doRequest(RequestSpecificationImpl.groovy:2054)
	at io.restassured.internal.http.HTTPBuilder.post(HTTPBuilder.java:349)
	at io.restassured.internal.http.HTTPBuilder$post$2.call(Unknown Source)
	at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:115)
	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:135)
	at io.restassured.internal.RequestSpecificationImpl.sendRequest(RequestSpecificationImpl.groovy:1180)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:101)
	at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:323)
	at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1217)
	at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1041)
	at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:821)
	at io.restassured.internal.RequestSpecificationImpl.invokeMethod(RequestSpecificationImpl.groovy)
	at org.codehaus.groovy.runtime.callsite.PogoInterceptableSite.call(PogoInterceptableSite.java:45)
	at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:115)
	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:151)
	at io.restassured.internal.filter.SendRequestFilter.filter(SendRequestFilter.groovy:30)
	at io.restassured.filter.Filter$filter$0.call(Unknown Source)
	at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
	at io.restassured.filter.Filter$filter.call(Unknown Source)
	at io.restassured.internal.filter.FilterContextImpl.next(FilterContextImpl.groovy:72)
	at io.restassured.filter.time.TimingFilter.filter(TimingFilter.java:56)
	at io.restassured.filter.Filter$filter.call(Unknown Source)
	at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
	at org.codehaus.groovy.runtime.callsite.Abstr

I guess we'll have to wait for someone with knowledge of these tests to take a look.

@machi1990
Copy link
Member

We probably need another way to handle it. Maybe the keycloak image has changed without us knowing - we are using the latest tag.

@sberyozkin
Copy link
Member

@jaikiran FYI, I've just rebuilt the master and run the oidc test with mvn install -Pdocker-keycloak -Ptest-keycloak -Dnative.
Looks like KC has not even started, and @geoand has pinned it to the fixed Keycloak version.

@sberyozkin
Copy link
Member

@jaikiran Actually a specific tag version was removed after Pedro's fix which made it unnecessary at a time. Can you please add :7.0.0 at https://github.com/quarkusio/quarkus/blob/master/ci-templates/native-build-steps.yaml#L39 ? It does look like we have to stick to the fixed version for the test purposes to avoid the periodic issues with the latest image

@sberyozkin
Copy link
Member

@jaikiran Latest tag was created 2 days ago which could explain why the tests started failing. So pinning it to 7.0.0 or 7.0.1 should be enough. But please re-enable the tests in your PR

@jaikiran jaikiran changed the title Temporarily disable BearerTokenAuthorizationTest Use a specific Keycloak docker image tag to run the integration tests Nov 18, 2019
@jaikiran
Copy link
Member Author

@jaikiran Latest tag was created 2 days ago which could explain why the tests started failing. So pinning it to 7.0.0 or 7.0.1 should be enough. But please re-enable the tests in your PR

@sberyozkin, thank you for that information. I think that indeed is the root cause of these failures. I have updated this PR to undo the disabling of the tests and instead use a specific Keycloak docker image tag 7.0.1 to run these tests. Let's see how the CI run goes now.

@stuartwdouglas
Copy link
Collaborator

stuartwdouglas commented Nov 18, 2019

I am closing this for now, as I had already submitted #5547 which also updates the fabric8 docker plugin used outside CI.

@gsmet gsmet added the triage/invalid This doesn't seem right label Nov 18, 2019
@jaikiran jaikiran deleted the qk-5536 branch July 4, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage/invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants