Deprecate `quarkus.native.resources.excludes` #50445

zakkak · 2025-10-07T10:54:49Z

The new reachability-metadata.json file doesn't allow the exclusion of
resources and uses globs for the inclusion of them.

See:

[GR-49770] Restrict the Expressivity of Patterns in resource-config.json oracle/graal#7487
[GR-54241] Introduce reachability-metadata.json to replace the various existing -config.json files oracle/graal#9048
[GR-68984] Fix the reachability-metadata schema and include it with GraalVM. oracle/graal#12255

Related to #41016

quarkus-bot · 2025-10-07T10:55:13Z

/cc @Karm (awt), @galderz (awt)

zakkak · 2025-10-07T10:55:49Z

extensions/awt/deployment/src/main/java/io/quarkus/awt/deployment/AwtProcessor.java

-                        .includePattern(".*/iio-plugin.*properties$") // Texts for e.g. exceptions strings
-                        .includePattern(".*/.*pf$") // Default colour profiles
+                        .includeGlobs("**/iio-plugin*.properties", // Texts for e.g. exceptions strings
+                                "**/*.pf") // Default colour profiles


@Karm please confirm that the new globs capture what you intended to capture with the patterns. Thanks

extensions/jaxb/deployment/src/main/java/io/quarkus/jaxb/deployment/JaxbProcessor.java

github-actions · 2025-10-07T11:42:03Z

🎊 PR Preview 31e401d has been successfully built and deployed to https://quarkus-pr-main-50445-preview.surge.sh/version/main/guides/

Images of blog posts older than 3 months are not available.
Newsletters older than 3 months are not available.

The new `reachability-metadata.json` file doesn't allow the exclusion of resources and uses globs for the inclusion of them. See: * oracle/graal#7487 * oracle/graal#9048 * oracle/graal#12255

zakkak · 2025-10-07T21:26:44Z

extensions/kotlin/deployment/src/main/java/io/quarkus/kotlin/deployment/KotlinProcessor.java

-        nativeResourcePatterns.produce(builder().includePatterns(
-                "META-INF/.*.kotlin_module$",
+        nativeResourcePatterns.produce(builder().includeGlobs(
+                "META-INF/**/*.kotlin_module",
                "META-INF/services/kotlin.reflect.*",
-                ".*.kotlin_builtins")
+                "**/*.kotlin_builtins")


@geoand please confirm that the new globs capture what you intended to capture with the patterns. Thanks

I don't remember for sure, but I'm pretty sure the pattern wasn't meant to capture the files in an arbitrary depth

Hmmm, I know for sure that *.kotlin_builtins didn't work, so it was meant to capture at least "some" depth. Furthermore, even if not meant to do so .* does capture arbitrary depth. What do you suggest?

If this works and attempts did it, let's go ahead with it

quarkus-bot · 2025-10-07T21:56:58Z

Status for workflow `Quarkus Documentation CI`

This is the status report for running Quarkus Documentation CI on commit abb226e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

quarkus-bot · 2025-10-07T23:20:38Z

Status for workflow `Quarkus CI`

This is the status report for running Quarkus CI on commit abb226e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Flaky tests - Develocity

⚙️ JVM Tests - JDK 25

📦 extensions/resteasy-reactive/rest/deployment

❌ io.quarkus.resteasy.reactive.server.test.stream.ErrorDuringStreamingTestCase.noFailure - History

expected: <200> but was: <201> - org.opentest4j.AssertionFailedError

org.opentest4j.AssertionFailedError: expected: <200> but was: <201>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:166)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:161)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:632)
	at io.quarkus.resteasy.reactive.server.test.stream.ErrorDuringStreamingTestCase.noFailure(ErrorDuringStreamingTestCase.java:54)

📦 extensions/smallrye-graphql/deployment

❌ io.quarkus.smallrye.graphql.deployment.CompletionStageTest.testSourcePost - History

1 expectation failed. Expected status code <200> but was <500>. - java.lang.AssertionError

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:483)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)

⚙️ Gradle Tests - JDK 17 Windows

📦 integration-tests/gradle

❌ io.quarkus.gradle.devmode.IncludedKotlinBuildDevModeTest.main - History

Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes 30 seconds. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes  30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at io.quarkus.gradle.devmode.QuarkusDevGradleTestBase.getHttpResponse(QuarkusDevGradleTestBase.java:165)

gsmet

I will let individual people confirm but this looks good to me (even if having exclusions made kinda sense to me).

zakkak requested review from Karm, geoand and vsevel October 7, 2025 10:54

quarkus-bot bot added area/core area/documentation area/graphics area/jaxb area/kotlin labels Oct 7, 2025

zakkak commented Oct 7, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

quarkus-bot bot added the triage/flaky-test label Oct 7, 2025

Deprecate quarkus.native.resources.excludes

abb226e

The new `reachability-metadata.json` file doesn't allow the exclusion of resources and uses globs for the inclusion of them. See: * oracle/graal#7487 * oracle/graal#9048 * oracle/graal#12255

zakkak force-pushed the 2025-10-07-deprecate-quarkus.native.resources.exclude branch from 7b02ea8 to abb226e Compare October 7, 2025 21:26

zakkak commented Oct 7, 2025

View reviewed changes

gsmet approved these changes Oct 8, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Deprecate `quarkus.native.resources.excludes` #50445

Deprecate `quarkus.native.resources.excludes` #50445

Uh oh!

zakkak commented Oct 7, 2025

Uh oh!

quarkus-bot bot commented Oct 7, 2025

Uh oh!

zakkak Oct 7, 2025

Uh oh!

Uh oh!

This comment has been minimized.

github-actions bot commented Oct 7, 2025 •

edited

Loading

Uh oh!

This comment has been minimized.

zakkak Oct 7, 2025

Uh oh!

geoand Oct 8, 2025

Uh oh!

zakkak Oct 8, 2025

Uh oh!

geoand Oct 8, 2025

Uh oh!

quarkus-bot bot commented Oct 7, 2025

Uh oh!

quarkus-bot bot commented Oct 7, 2025 •

edited by github-actions bot

Loading

Uh oh!

gsmet left a comment

Uh oh!

Uh oh!

Deprecate quarkus.native.resources.excludes #50445

Are you sure you want to change the base?

Deprecate quarkus.native.resources.excludes #50445

Uh oh!

Conversation

zakkak commented Oct 7, 2025

Uh oh!

quarkus-bot bot commented Oct 7, 2025

Uh oh!

zakkak Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment has been minimized.

github-actions bot commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

zakkak Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

geoand Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

zakkak Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

geoand Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

quarkus-bot bot commented Oct 7, 2025

Status for workflow Quarkus Documentation CI

Uh oh!

quarkus-bot bot commented Oct 7, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Status for workflow Quarkus CI

Flaky tests - Develocity

⚙️ JVM Tests - JDK 25

📦 extensions/resteasy-reactive/rest/deployment

📦 extensions/smallrye-graphql/deployment

⚙️ Gradle Tests - JDK 17 Windows

📦 integration-tests/gradle

Uh oh!

gsmet left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Deprecate `quarkus.native.resources.excludes` #50445

Deprecate `quarkus.native.resources.excludes` #50445

github-actions bot commented Oct 7, 2025 •

edited

Loading

Status for workflow `Quarkus Documentation CI`

quarkus-bot bot commented Oct 7, 2025 •

edited by github-actions bot

Loading

Status for workflow `Quarkus CI`