Skip to content

Conversation

mjurc
Copy link
Contributor

@mjurc mjurc commented Sep 23, 2025

  • Adding Maven compile plugin configuration ensuring that the dependencies of annotation processor are managed by Quarkus to Jakarta Data docs.

* Adding Maven compile plugin configuration ensuring that the
  dependencies of annotation processor are managed by Quarkus
  to Jakarta Data docs.
Copy link

quarkus-bot bot commented Sep 23, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 1fd68b1.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link

github-actions bot commented Sep 23, 2025

🙈 The PR is closed and the preview is expired.

@yrodiere
Copy link
Member

Thanks, but do you have some context @mjurc?

From what I understand, the annotation processor itself would have its version managed by the Quarkus BOM. Only transitifive dependencies might not.

So this would only matter if dependencies of the annotation processor diverged from what is being managed by Quarkus.

Did you notice any such dependency, and if so may I ask which one?

@mjurc
Copy link
Contributor Author

mjurc commented Sep 24, 2025

@yrodiere Yes, that's the way I understand it too.

We've just had that happen in RHBQ with https://issues.redhat.com/browse/QUARKUS-6578. I'm not sure how possible it's with Quarkus, but I'd say there's a possibility

@aloubyansky
Copy link
Member

Yes, @yrodiere, it does happen sometimes.

  1. First of all, this Hibernate artifact comes from a different repository where dependency management is not guaranteed to be aligned with quarkus-bom.
  2. We may sometimes patch CVEs by enforcing a version constraint of a particular JAR in a platform BOM. To make sure the patch would be applied to all dependencies used in a build, we need to enforce the BOMs on annotation processors.
  3. Some organizations have particular rebuild from source processes where this becomes even more nuanced.

@yrodiere
Copy link
Member

Right, I understand it can happen in theory, I just wanted to know which dependency caused this specific instance. Because that could be an oversight from our part.

@yrodiere
Copy link
Member

Though the RHBQ thing answers my question :) Thanks

@yrodiere
Copy link
Member

Opened https://hibernate.atlassian.net/browse/HHH-19804 to fix upstream documentation too

@yrodiere
Copy link
Member

@marko-bekhta you may want to fix the documentation for the Hibernate Search processor as well?

@marko-bekhta
Copy link
Contributor

@marko-bekhta you may want to fix the documentation for the Hibernate Search processor as well?

thanks! that's good to know 🙂

@aloubyansky aloubyansky merged commit 58a0169 into quarkusio:main Sep 24, 2025
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.29 - main milestone Sep 24, 2025
@gsmet gsmet modified the milestones: 3.29 - main, 3.28.2 Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants