Skip to content

Conversation

mjurc
Copy link

@mjurc mjurc commented Sep 25, 2025

  • Adding configuration to Maven compiler plugin to ensure that annotation processor dependency resolution respects dependency management of the project rather than dependencies of the processor for hibernate-orm-jakarta-data quickstart.

Also see quarkusio/quarkus#50243

Check list:

Your pull request:

  • targets the development branch
  • uses the 999-SNAPSHOT version of Quarkus
  • has tests (mvn clean test)
  • works in native (mvn clean package -Pnative)
  • has integration/native tests (mvn clean verify -Pnative)
  • makes sure the associated guide must not be updated
  • links the guide update pull request (if needed)
  • updates or creates the README.md file (with build and run instructions)
  • for new quickstart, is located in the directory component-quickstart
  • for new quickstart, is added to the root pom.xml and README.md

* Adding configuration to Maven compiler plugin to ensure that
  annotation processor dependency resolution respects dependency
  management of the project rather than dependencies of the processor
  for hibernate-orm-jakarta-data quickstart.
@mjurc
Copy link
Author

mjurc commented Sep 25, 2025

btw, how do I get this backported to 3.27 branch? This should be applied there too. Should I just open another MR, or is there a different mechanism?

This comment has been minimized.

@mjurc
Copy link
Author

mjurc commented Sep 26, 2025

@yrodiere would you mind giving this a review?

@yrodiere
Copy link
Member

LGTM, thanks. I don't see how the test failure could be related, but given what it is, it's likely flaky... I'll restart it to be sure.

@yrodiere
Copy link
Member

btw, how do I get this backported to 3.27 branch? This should be applied there too. Should I just open another MR, or is there a different mechanism?

I don't remember ever having to backport beyond main so not sure, but I imagine you need to just open a PR, yes.

Copy link

quarkus-bot bot commented Sep 26, 2025

Status for workflow Pull Request Build - development

This is the status report for running Pull Request Build - development on commit 3b1f100.

Failing Jobs

Status Name Step Failures Logs Raw logs
Build - JDK 17 Build with Maven Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Build - JDK 17 #

- Failing: amqp-quickstart/amqp-quickstart-processor 

📦 amqp-quickstart/amqp-quickstart-processor

org.acme.amqp.processor.QuoteProcessorTest.testProcessor line 46 - More details - Source on GitHub

java.lang.AssertionError: Expected 1 items.  Only 0 items have been received.
	at io.smallrye.mutiny.helpers.test.AssertSubscriber.awaitItemEvents(AssertSubscriber.java:684)
	at io.smallrye.mutiny.helpers.test.AssertSubscriber.awaitItems(AssertSubscriber.java:440)
	at io.smallrye.mutiny.helpers.test.AssertSubscriber.awaitItems(AssertSubscriber.java:411)
	at org.acme.amqp.processor.QuoteProcessorTest.testProcessor(QuoteProcessorTest.java:46)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.junit.QuarkusTestExtension.runExtensionMethod(QuarkusTestExtension.java:998)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:846)

@gsmet
Copy link
Member

gsmet commented Sep 26, 2025

Yes please open a PR targeting 3.27.

@mjurc
Copy link
Author

mjurc commented Sep 29, 2025

I'm kind of thinking this PR couldn't have changed the failing quickstart - can this be merged?

@yrodiere
Copy link
Member

📦 amqp-quickstart/amqp-quickstart-processor

org.acme.amqp.processor.QuoteProcessorTest.testProcessor line 46 - More details - Source on GitHub

java.lang.AssertionError: Expected 1 items.  Only 0 items have been received.
	at io.smallrye.mutiny.helpers.test.AssertSubscriber.awaitItemEvents(AssertSubscriber.java:684)
	at io.smallrye.mutiny.helpers.test.AssertSubscriber.awaitItems(AssertSubscriber.java:440)
	at io.smallrye.mutiny.helpers.test.AssertSubscriber.awaitItems(AssertSubscriber.java:411)
	at org.acme.amqp.processor.QuoteProcessorTest.testProcessor(QuoteProcessorTest.java:46)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.junit.QuarkusTestExtension.runExtensionMethod(QuarkusTestExtension.java:998)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:846)

Seeing the same failure there: #1558

Doesn't look like there is a clear maintainer for that quickstart, so I suppose the next person to be fed up by the failures will take care of it. I can't right now.

In any case, it's unrelated to this PR. Merging.

@yrodiere yrodiere merged commit 400db27 into quarkusio:development Sep 30, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants