-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Ensure annotation processor respects depmgmt with Jakarta Data #1569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure annotation processor respects depmgmt with Jakarta Data #1569
Conversation
* Adding configuration to Maven compiler plugin to ensure that annotation processor dependency resolution respects dependency management of the project rather than dependencies of the processor for hibernate-orm-jakarta-data quickstart.
btw, how do I get this backported to 3.27 branch? This should be applied there too. Should I just open another MR, or is there a different mechanism? |
This comment has been minimized.
This comment has been minimized.
@yrodiere would you mind giving this a review? |
LGTM, thanks. I don't see how the test failure could be related, but given what it is, it's likely flaky... I'll restart it to be sure. |
I don't remember ever having to backport beyond main so not sure, but I imagine you need to just open a PR, yes. |
Status for workflow
|
Status | Name | Step | Failures | Logs | Raw logs |
---|---|---|---|---|---|
❌ | Build - JDK 17 | Build with Maven |
Failures | Logs | Raw logs |
Full information is available in the Build summary check run.
Failures
⚙️ Build - JDK 17 #
- Failing: amqp-quickstart/amqp-quickstart-processor
📦 amqp-quickstart/amqp-quickstart-processor
❌ org.acme.amqp.processor.QuoteProcessorTest.testProcessor
line 46
- More details - Source on GitHub
java.lang.AssertionError: Expected 1 items. Only 0 items have been received.
at io.smallrye.mutiny.helpers.test.AssertSubscriber.awaitItemEvents(AssertSubscriber.java:684)
at io.smallrye.mutiny.helpers.test.AssertSubscriber.awaitItems(AssertSubscriber.java:440)
at io.smallrye.mutiny.helpers.test.AssertSubscriber.awaitItems(AssertSubscriber.java:411)
at org.acme.amqp.processor.QuoteProcessorTest.testProcessor(QuoteProcessorTest.java:46)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at io.quarkus.test.junit.QuarkusTestExtension.runExtensionMethod(QuarkusTestExtension.java:998)
at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:846)
Yes please open a PR targeting 3.27. |
I'm kind of thinking this PR couldn't have changed the failing quickstart - can this be merged? |
Seeing the same failure there: #1558 Doesn't look like there is a clear maintainer for that quickstart, so I suppose the next person to be fed up by the failures will take care of it. I can't right now. In any case, it's unrelated to this PR. Merging. |
Also see quarkusio/quarkus#50243
Check list:
Your pull request:
development
branch999-SNAPSHOT
version of Quarkusmvn clean test
)mvn clean package -Pnative
)mvn clean verify -Pnative
)README.md
file (with build and run instructions)pom.xml
andREADME.md