Account for the null root bean when performing value validation #49990
+88
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/hibernate-validator
|
/cc @gsmet (hibernate-orm) |
when Validator#validateValue is used then the root validation context won't have the root bean (i.e. it'll be null), but at the same time we've already retrieved the value since we passed it to the validator call, hence no need to check for reachability
marko-bekhta
force-pushed
the
fix/i49987-traversable-resolver-for-validatevalue
branch
from
8ff70d6 to
9751ce1
Compare
This comment has been minimized.
This comment has been minimized.
yrodiere
approved these changes
Sep 11, 2025
|
Thank you! LGTM. |
geoand
approved these changes
Sep 15, 2025
geoand
added
the
triage/waiting-for-ci
Status for workflow
|
quarkus-bot
bot
added
kind/bugfix
and removed
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
Validator#validateValue()is called, then the root validation context won't have the root bean (i.e. it'll benull), but at the same time, we've already retrieved the value since we are passing it to the validator method, hence no need to check for reachability there.This affects only the value validation.
Since the causing change was included in the 3.24.1, we'd probably want to backport this to all still maintained versions...