-
Notifications
You must be signed in to change notification settings - Fork 3k
Do not rely on JPATraversableResolver / add JPA aware resolver only if ORM is enabled #48458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not rely on JPATraversableResolver / add JPA aware resolver only if ORM is enabled #48458
Conversation
/cc @gsmet (hibernate-orm) |
<dependency> | ||
<groupId>io.quarkus</groupId> | ||
<artifactId>quarkus-hibernate-validator-spi</artifactId> | ||
<optional>true</optional> <!-- conditional dependency --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually SPI modules aren't optional, because the presence of the SPI doesn't mean that the actual extension that leverages the build items (in this case quarkus-hibernate-validator-deployment
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, got it 😃 ! Let me clean it up and see if it all still works (it should, right? but 😃)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should yeah :)
This comment has been minimized.
This comment has been minimized.
🎊 PR Preview 2c5bbae has been successfully built and deployed to https://quarkus-pr-main-48458-preview.surge.sh/version/main/guides/
|
4f22d8d
to
28a73f6
Compare
Status for workflow
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we are not pushing things a bit too far but only time will tell :).
Thanks for the PR!
This PR tries to address a few things
JPATraversalbeResolver
I was thinking that we could skip even more operations when we are within Quarkus. From what I can see the current implementation in the JPA would eventually delegate toProviderUtil
that have its own implementation in Quarkus, which is shared by ORM/Reactive. I was thinking that we could also try to eliminate the extra calls to retrieve the persistence providers and also the loops if we know that all we'd get isProviderUtil
.