Skip to content

Conversation

jponge
Copy link
Member

@jponge jponge commented Sep 4, 2025

This fixes Netty CVEs: CVE-2025-58057 and CVE-2025-58056

@quarkus-bot quarkus-bot bot changed the title Bump to Vert.x 4.5.21 and Netty 4.1.126.Final [3.20] Bump to Vert.x 4.5.21 and Netty 4.1.126.Final Sep 4, 2025
Copy link

quarkus-bot bot commented Sep 4, 2025

/cc @aloubyansky (3.20), @gastaldi (3.20), @gsmet (3.20), @jmartisk (3.20), @rsvoboda (3.20)

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/netty area/vertx labels Sep 4, 2025
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure we have everything sorted out in #49867 first before merging this.

This comment has been minimized.

This comment has been minimized.

@jponge
Copy link
Member Author

jponge commented Sep 8, 2025

I messed up with my branch

jponge and others added 4 commits September 8, 2025 15:17
We override the authority here so we need to be extra careful.
Also fixes Vertx context being created in tests but never been cleared.

Co-authored-by: Clement Escoffier <[email protected]>
This fixes Netty/BouncyCastle issues.
@jponge jponge changed the title [3.20] Bump to Vert.x 4.5.21 and Netty 4.1.126.Final [3.20] Bump to Vert.x 4.5.21 and Netty 4.1.127.Final Sep 8, 2025
@jponge jponge force-pushed the deps/vertx-4.5.21-3.20 branch from ea0b8dd to 046b26e Compare September 8, 2025 13:19
@jponge
Copy link
Member Author

jponge commented Sep 8, 2025

@jmartisk this should be good, but you might want to squash the commits when it's good to merge

Copy link

quarkus-bot bot commented Sep 8, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 046b26e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@marcelstoer
Copy link
Contributor

@jponge thanks for the updates, much appreciated! Would anyone care to explain how such fixes will find their way into RHBQ 3.20 releases? I previously tried through https://issues.redhat.com/projects/QUARKUS (using the corporate account) but got nowhere.

@jmartisk
Copy link
Contributor

jmartisk commented Sep 9, 2025

@jponge thanks for the updates, much appreciated! Would anyone care to explain how such fixes will find their way into RHBQ 3.20 releases? I previously tried through https://issues.redhat.com/projects/QUARKUS (using the corporate account) but got nowhere.

This PR will first get merged into the 3.20.3 community release, which will then be the base for the corresponding RHBQ release.

@marcelstoer
Copy link
Contributor

marcelstoer commented Sep 9, 2025

This landing in 3.20.3 is important information, thanks. Should it be assigned to the 3.20.3 milestone? Or does this happen only once it's merged?

the base for the corresponding RHBQ release

Given the above, this for us means that there's no need waiting for a new RHBQ release that includes the Vert.x and Netty vulnerability fixes. RHBQ 3.20.3.GA is due only in a month. We'll now manage those dependencies manually.

@jmartisk
Copy link
Contributor

jmartisk commented Sep 9, 2025

Should it be assigned to the 3.20.3 milestone? Or does this happen only once it's merged?

Yes, that is exactly how we do it :)

@jmartisk jmartisk merged commit 03c128f into quarkusio:3.20 Sep 10, 2025
55 checks passed
@jmartisk jmartisk added this to the 3.20.3 milestone Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants