-
Notifications
You must be signed in to change notification settings - Fork 3k
Bump to Vert.x 4.5.21 and Netty 4.1.127.Final #49867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/cc @brunobat (opentelemetry), @radcortez (opentelemetry) |
...c/test/java/io/quarkus/opentelemetry/runtime/tracing/intrumentation/vertx/VertxUtilTest.java
Show resolved
Hide resolved
We have failures in JVM / native mode for some HTTP compression tests, see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we also need to update the version in independent-projects/vertx-utils/pom.xml
(is that the cause of the failure?)
Good catch @jmartisk, let me see if this caused a mis-alignment |
It's a needed POM bump, but it doesn't solve the problem. |
feaf677
to
5286496
Compare
Also /cc @mkouba |
Do you have a stack trace or something? |
Ok, so, it's not nice. When we use the Vert.x web client to retrieve the response, it got cut. It only does it when the compression use "deflate" |
It cut just before |
Hum, every |
Someone would have to check, but according to https://w4ke.info/2025/06/18/funky-chunks.html, we may have an illegal test in the sense that it introduces "funky chunks". I'm surprised, as we mostly only introduce |
Not sure actually - I've removed the line jump and still see cut content. |
The content appears to be compressed correctly, but the issue arises when we decompress it in the test to verify if it matches the original content. We use the Netty API directly; I don't see anything odd so far. |
Also what I'm looking at (but no expert in that area) |
Ok, got it. |
Apply the following:
|
Let me check that + fix something else we discussed with @cescoffier |
bouncy-castle-fips-jsse test is failing, I'm in a co-working space right now, it expires in an hour, so it is unlikely I'll find anything now, will look later this evening. If this PR must get in ASAP, I suggest ignore this test failure and go ahead with the merge and open an issue assigned to me to check the test failure. |
The trace for the bouncycastle is here:
Specifically,
I'm really not sure what can be done at the Quarkus level. Looks like some changes happened at the Netty level. I'll try to check the history of changes later this evening |
This comment has been minimized.
This comment has been minimized.
Not sure about this. I just pushed the test fix commit to the 3.20 / 3.15 backports, let's see how these branches do. |
I've opened netty/netty#15627 |
Discussion happening in netty/netty#15627 (comment) |
@holly-cummins Hi Holly, Julien confirmed the Netty code related to loading BouncyCastle classes (JSSE ones in particular) caused two Quarkus BC JSSE integrations tests failing. Can you please have a look at the linked Netty issue, if you can spot something that can clarify why the Netty BouncyCastle class loading related update caused the failure, then please comment |
@holly-cummins We're all good, this has been confirmed as a Netty bug 👍 |
Nice work everyone! |
Thanks @jponge for independently confirming the regression with the local Netty build and working with Norman to verify his fix |
My pleasure 😄 This is the magic of OSS (+ kudos Norman) |
This fixes Netty CVEs: CVE-2025-58057 and CVE-2025-58056
We override the authority here so we need to be extra careful.
Also fixes Vertx context being created in tests but never been cleared. Co-authored-by: Clement Escoffier <[email protected]>
This fixes Netty/BouncyCastle issues.
258afe1
to
8021e27
Compare
@cescoffier see the last commit (and PR title already updated) |
This fixes Netty CVEs: CVE-2025-58057 and CVE-2025-58056 This is a backport of quarkusio#49867
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks a lot!
This fixes Netty CVEs: CVE-2025-58057 and CVE-2025-58056