[3.25] Account for Formula properties when detecting JSON/XML columns #49260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @gsmet (hibernate-orm) |
quarkus-bot
bot
changed the title
This comment has been minimized.
This comment has been minimized.
gsmet
requested changes
Aug 1, 2025
| columns = c.getElement().getColumns(); | ||
| try { | ||
| for (PersistentClass persistentClass : metadata.getEntityBindings()) { | ||
| for (Property property : persistentClass.getProperties()) { |
There was a problem hiding this comment.
I think I would very much prefer having the try/catch in the loop and only ignoring this property if failing.
That would be a lot safer.
marko-bekhta
force-pushed
the
fix/3.25/i49258-formula-column-json-mapping
branch
from
4ec284f to
9cf9e9f
Compare
marko-bekhta
force-pushed
the
fix/3.25/i49258-formula-column-json-mapping
branch
from
9cf9e9f to
65e22d0
Compare
Status for workflow
|
|
Closing this one in favour ofthe changes suggested in: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this against a 3.25 branch to make it easier to apply.
For the main branch, I'll have to add a bit more as we switched to a failing behavior there so the tests won't work the same + there's that other issue discused here: #dev > Change the ORM's XML/JSON built-in format mapper default @ 💬, working on a fix for it and will comibne it all together